New issue
Advanced search Search tips

Issue 636087 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
pdr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove compositor-specific accelerated_2d_canvas_enabled preference override

Project Member Reported by pdr@chromium.org, Aug 9 2016 
Layouttests in the compositing/ directory override the default preferences to enable accelerated 2d canvas (and enable mock scrollbars)[1]. These preferences are overridden in a hacky and non-obvious way and we should move these preference changes to a more common pattern.

I can think of two approaches that might work:
1) Add an internals api accessible from the testRunner javascript hooks to enable accelerated 2d canvas. We could then just add this line to the canvas tests in compositing/ that need it.
2) Move the canvas tests out of compositing and use the virtual test suite infrastructure to run them with --enable-accelerated-2d-canvas.

[1] https://cs.chromium.org/chromium/src/content/shell/browser/layout_test/blink_test_controller.cc?l=369
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 10 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by schenney@chromium.org, Aug 10 2017

Cc: pdr@chromium.org
Labels: -Hotlist-Recharge-Cold Test-Layout PaintTeamTriaged-20170810 BugSource-Team OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)
Was this the problem causing flaky tests based on out of order execution? I could take this on if it's still an issue.
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 10

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by schenney@chromium.org, Aug 10

Status: Available (was: Untriaged)
Should probably do option (1).
►

Sign in to add a comment