New issue
Advanced search Search tips

Issue 636085 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Factor out container_config_parser

Project Member Reported by ksanthanam@google.com, Aug 9 2016

Issue description

Factor out container_config_parser.cc from login_manager so that it can be used by other programs.
 
Labels: -Pri-3 M-55 Pri-2
Owner: dgreid@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 Deleted

Comment 3 Deleted

Comment 4 Deleted

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/6b590e6afde3a3f387a37552756f5b1abd75eb32

commit 6b590e6afde3a3f387a37552756f5b1abd75eb32
Author: Dylan Reid <dgreid@chromium.org>
Date: Fri Oct 28 02:10:53 2016

container_utils: Add parser for OCI config.json

Add a parser that outputs structs representing the configuration given
in an OCI config.json.  The JSON spec can be found here:
https://github.com/opencontainers/runtime-spec/tree/v1.0.0-rc1.
This parses only a subset of the fields, but covers those needed to
start the first containers we will add.

BUG= 636085 
TEST=Added container_config_parser_unittest

Change-Id: Ie2fd6a6952b900127d9303a5464a9cd2dc0f5ea7
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/405111
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/6b590e6afde3a3f387a37552756f5b1abd75eb32/container_utils/container_utils.gyp
[add] https://crrev.com/6b590e6afde3a3f387a37552756f5b1abd75eb32/container_utils/container_config_parser.cc
[add] https://crrev.com/6b590e6afde3a3f387a37552756f5b1abd75eb32/container_utils/container_config_parser.h
[add] https://crrev.com/6b590e6afde3a3f387a37552756f5b1abd75eb32/container_utils/container_config_parser_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b0a727782adaa5838bb1e47518cd1d99278c9b4f

commit b0a727782adaa5838bb1e47518cd1d99278c9b4f
Author: Dylan Reid <dgreid@chromium.org>
Date: Thu Nov 03 16:27:50 2016

container_utils: Parse oci seccomp node

This will allow for specifying the seccomp parameters to containers that
will be run by the container startup tool.

BUG= 636085 
TEST=container_config_parser_unittest

Change-Id: I8fab8eba67e0a4f964caa045f03e89d2a69d810c
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/407359
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b0a727782adaa5838bb1e47518cd1d99278c9b4f/container_utils/oci_config.h
[modify] https://crrev.com/b0a727782adaa5838bb1e47518cd1d99278c9b4f/container_utils/container_config_parser.cc
[modify] https://crrev.com/b0a727782adaa5838bb1e47518cd1d99278c9b4f/container_utils/container_config_parser_unittest.cc

Comment 7 by dgreid@chromium.org, Nov 29 2016

Status: Fixed (was: Assigned)

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: OS>Systems>Containers

Sign in to add a comment