New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636081 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
finnur@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Site Settings - list button to short

Project Member Reported by dschuyler@chromium.org, Aug 9 2016 
In chrome://md-settings in site settings within a category (such as Cookies), the add site row button is not tall enough to match specs. It should be 44px.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46f26b6a2cd85f8ccf1fc08c2194562d6eb1d538

commit 46f26b6a2cd85f8ccf1fc08c2194562d6eb1d538
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Aug 11 02:19:14 2016

[MD settings] button container to list button in site settings

This CL fixes an issue with the add site row button not being tall
enough. The fix changes it from a paper-button to use a .list-button
class instead (which is how it's done elsewhere in md-settings).

BUG= 636081 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2234433002
Cr-Commit-Position: refs/heads/master@{#411227}

[modify] https://crrev.com/46f26b6a2cd85f8ccf1fc08c2194562d6eb1d538/chrome/browser/resources/settings/site_settings/site_list.html

Comment 2 by dschuyler@chromium.org, Aug 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment