New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636053 link

Starred by 1 user
Status: Fixed
Owner:
█ robhogan@chromium.org
Use other robhogan account instead.
Closed: Sep 2017
Cc:
hua...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 591500


Sign in to add a comment

Failure in printing/thead-repeats-at-top-of-each-page-multiple-tables

Project Member Reported by hua...@chromium.org, Aug 9 2016 
New tests added failed on Windows:

printing/thead-repeats-at-top-of-each-page-multiple-tables.html
virtual/threaded/printing/thead-repeats-at-top-of-each-page-multiple-tables.html

Looks like this is caused by:
https://codereview.chromium.org/2221393003/

Comment 1 by robhogan@chromium.org, Aug 9 2016 

I think you just need to add platform-specific expected.txt results for mac and win. For some reason the autorebaseline didn't generate and land any.

Comment 2 by hua...@chromium.org, Aug 9 2016 

How long would that take?  If it's fast, could you land a patch soon?  Or if it will take a while then perhaps we should revert first, then add the files in the same CL.  Thanks!

Comment 3 by hua...@chromium.org, Aug 9 2016

Cc: -robho...@gmail.com hua...@chromium.org
Owner: robho...@gmail.com

Comment 4 by robhogan@chromium.org, Aug 9 2016 

I'd prefer if you mark the two tests as failing in TestExpectations and then assign to me.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8c129077f568199128469684cc35237d1dcebe9

commit f8c129077f568199128469684cc35237d1dcebe9
Author: robhogan <robhogan@gmail.com>
Date: Tue Aug 09 21:41:20 2016

Mark new for manual rebaseline on mac and win

Test added by https://codereview.chromium.org/2221393003/ needs manual rebaseline.

TBR=huangs@chromium.org,wangxianzhu@chromium.org, esprehn@chromium.org

BUG= 636053 

Review-Url: https://codereview.chromium.org/2224273004
Cr-Commit-Position: refs/heads/master@{#410834}

[modify] https://crrev.com/f8c129077f568199128469684cc35237d1dcebe9/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee55744cdbca41238de847ba10224079ba8f905a

commit ee55744cdbca41238de847ba10224079ba8f905a
Author: bsep <bsep@chromium.org>
Date: Mon Aug 15 23:02:54 2016

Revert of Manual rebaseline for r410657 (patchset #2 id:20001 of https://codereview.chromium.org/2244803002/ )

Reason for revert:
Causing reliable failure on the Win10 bot (Win7 looks fine). Example failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/13628

Original issue's description:
> Manual rebaseline for r410657
>
> TBR=eae@chromium.org
>
> BUG= 636053 
>
> Committed: https://crrev.com/3c5b5cff86c97d866bd8843607b7e59aa4b8f1cd
> Cr-Commit-Position: refs/heads/master@{#412036}

TBR=eae@chromium.org,robhogan@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 636053 

Review-Url: https://codereview.chromium.org/2251533002
Cr-Commit-Position: refs/heads/master@{#412084}

[modify] https://crrev.com/ee55744cdbca41238de847ba10224079ba8f905a/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/911544e1a3a95344924dd6e1d25a9706c4de243a/third_party/WebKit/LayoutTests/platform/mac/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.txt
[delete] https://crrev.com/911544e1a3a95344924dd6e1d25a9706c4de243a/third_party/WebKit/LayoutTests/platform/win/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.txt
[rename] https://crrev.com/ee55744cdbca41238de847ba10224079ba8f905a/third_party/WebKit/LayoutTests/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.txt
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f1d4ece5c807518990d627438258dff2ee9509a

commit 7f1d4ece5c807518990d627438258dff2ee9509a
Author: rjwright <rjwright@chromium.org>
Date: Wed Aug 17 05:49:18 2016

Revert of Manual rebaseline for r410657 (patchset #4 id:60001 of https://codereview.chromium.org/2244803002/ )

Reason for revert:
Still causing reliable failure on the Win10 bot (Win7 looks fine). Example failure:https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/13681

Original issue's description:
> Manual rebaseline for r410657
>
> TBR=eae@chromium.org
>
> BUG= 636053 
>
> Committed: https://crrev.com/00d57f5d47ecb4271fb5f386739ac52f4414c6c5
> Cr-Commit-Position: refs/heads/master@{#412403}

TBR=eae@chromium.org,robhogan@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 636053 

Review-Url: https://codereview.chromium.org/2248253003
Cr-Commit-Position: refs/heads/master@{#412454}

[modify] https://crrev.com/7f1d4ece5c807518990d627438258dff2ee9509a/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/73fbdfd37085ebb05446a26f9f41a6afbd12ada5/third_party/WebKit/LayoutTests/platform/mac/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.txt
[delete] https://crrev.com/73fbdfd37085ebb05446a26f9f41a6afbd12ada5/third_party/WebKit/LayoutTests/platform/win/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.txt
[rename] https://crrev.com/7f1d4ece5c807518990d627438258dff2ee9509a/third_party/WebKit/LayoutTests/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.txt

Comment 11 by robhogan@chromium.org, Aug 17 2016

Blockedon: 591500
Labels: -Pri-1 Pri-3

Comment 12 by robho...@gmail.com, Dec 14 2016

Owner: robhogan@chromium.org

Comment 13 by qyears...@chromium.org, May 16 2017 

Note, there are still NeedsManualRebaseline lines in TestExpectations associated with this bug. It looks like the last manual rebaseline was reverted; I wonder if things are different now, or something was wrong with that rebaseline?

When doing the next manual rebaseline we should definitely try the change with all of the tryserver.blink try bots before landing.
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b98108ff7d2ffcbc4a5de517dab179431280026

commit 6b98108ff7d2ffcbc4a5de517dab179431280026
Author: Robert Hogan <robhogan@gmail.com>
Date: Tue Aug 01 10:40:31 2017

Re-enable repeating thead tests on Mac and Win

Bug:  636053 
Change-Id: I9ed72d459d43f2a0113e4c46a496f6ecf65665d6
Reviewed-on: https://chromium-review.googlesource.com/593308
Reviewed-by: Robert Hogan <robhogan@gmail.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Cr-Commit-Position: refs/heads/master@{#490936}
[modify] https://crrev.com/6b98108ff7d2ffcbc4a5de517dab179431280026/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/6b98108ff7d2ffcbc4a5de517dab179431280026/third_party/WebKit/LayoutTests/platform/mac/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.txt
[add] https://crrev.com/6b98108ff7d2ffcbc4a5de517dab179431280026/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.txt
[add] https://crrev.com/6b98108ff7d2ffcbc4a5de517dab179431280026/third_party/WebKit/LayoutTests/platform/win/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.png
[add] https://crrev.com/6b98108ff7d2ffcbc4a5de517dab179431280026/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.png
[delete] https://crrev.com/9cf09cad4121d7465d99c753bf30ccb604ae18a9/third_party/WebKit/LayoutTests/platform/win7/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.png
[delete] https://crrev.com/9cf09cad4121d7465d99c753bf30ccb604ae18a9/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/thead-repeats-at-top-of-each-page-multiple-tables-expected.png

Comment 15 by robhogan@chromium.org, Sep 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment