New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636052 link

Starred by 1 user
Status: Fixed
Owner:
asvitk...@chromium.org
Closed: Aug 2016
Cc:
isherman@chromium.org
thestig@chromium.org
foolip@chromium.org
gayane@chromium.org
steve...@chromium.org
skare@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"MetricsServiceBrowserTest.CloseRenderersNormally" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 9 2016 
"MetricsServiceBrowserTest.CloseRenderersNormally" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBNZXRyaWNzU2VydmljZUJyb3dzZXJUZXN0LkNsb3NlUmVuZGVyZXJzTm9ybWFsbHkM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by esprehn@chromium.org, Aug 9 2016 

MetricsServiceBrowserTest.CloseRenderersNormally (run #2):
[ RUN      ] MetricsServiceBrowserTest.CloseRenderersNormally
[2364:4904:0808/204745:FATAL:metrics_state_manager.cc(260)] Check failed: !client_info || base::IsValidGUID(client_info->client_id).
Backtrace:
	base::debug::StackTrace::StackTrace [0x0237D3A7+23]
	logging::LogMessage::~LogMessage [0x02338381+49]
	metrics::MetricsStateManager::LoadClientInfoAndMaybeMigrate [0x02DF5254+439]
	metrics::MetricsStateManager::ForceClientIdCreation [0x02DF4E4F+132]
	metrics::MetricsService::EnableRecording [0x02DEE343+119]
	metrics::MetricsService::StartRecordingForTests [0x02DF024A+15]
	metrics_services_manager::MetricsServicesManager::UpdatePermissions [0x039E879F+102]
	metrics_services_manager::MetricsServicesManager::UpdateUploadPermissions [0x039E8886+28]
	ChromeBrowserMainParts::StartMetricsRecording [0x025FD644+139]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x025FBC41+546]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x025FB9E7+164]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x0160FDAC+112]
	content::StartupTaskRunner::RunAllTasksNow [0x01832B4D+27]
	content::BrowserMainLoop::CreateStartupTasks [0x0160E16A+387]
	content::BrowserMainRunnerImpl::Initialize [0x01611045+644]
	content::BrowserMain [0x0160CE6F+153]
	content::RunNamedProcessTypeMain [0x023214E0+206]
	content::ContentMainRunnerImpl::Run [0x023213E1+274]
	content::ContentMain [0x023207AD+35]
	content::BrowserTestBase::SetUp [0x026C5DEA+945]
	InProcessBrowserTest::SetUp [0x023C4CE0+246]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x02A94508+32]
	testing::Test::Run [0x02A9B28C+51]
	testing::TestCase::Run [0x02A9B362+133]
	testing::internal::UnitTestImpl::RunAllTests [0x02A9B6E2+434]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x02A9454C+32]
	testing::UnitTest::Run [0x02A9B50B+133]
	base::TestSuite::Run [0x023CD544+95]
	ChromeTestSuiteRunner::RunTestSuite [0x04951212+40]
	content::LaunchTests [0x026BFFA5+592]
	LaunchChromeTests [0x049511D9+49]
	main [0x0494FE09+94]
	__scrt_common_main_seh [0x049154AC+255] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:255)
	BaseThreadInitThunk [0x764A336A+18]
	RtlInitializeExceptionChain [0x76EE92B2+99]
	RtlInitializeExceptionChain [0x76EE9285+54]

Comment 2 by esprehn@chromium.org, Aug 9 2016

Cc: thestig@chromium.org steve...@chromium.org isherman@chromium.org
Components: Internals>Metrics
Owner: gayane@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by esprehn@chromium.org, Aug 9 2016

Cc: gayane@chromium.org foolip@chromium.org
Owner: asvitk...@chromium.org
Looks like the same issue as 635770.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0b0de291ba041ed4bb40a0e3ead7d8324acdd49

commit f0b0de291ba041ed4bb40a0e3ead7d8324acdd49
Author: esprehn <esprehn@chromium.org>
Date: Tue Aug 09 21:34:44 2016

Disable flaky MetricsServiceBrowserTest#CloseRenderersNormally.

BUG= 636052 
TBR=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2231443003
Cr-Commit-Position: refs/heads/master@{#410830}

[modify] https://crrev.com/f0b0de291ba041ed4bb40a0e3ead7d8324acdd49/chrome/browser/metrics/metrics_service_browsertest.cc

Comment 6 by esprehn@chromium.org, Aug 9 2016

Labels: -Sheriff-Chromium

Comment 7 by asvitk...@chromium.org, Aug 13 2016 

This was caused by https://bugs.chromium.org/p/chromium/issues/detail?id=635255. Given that's now fixed, reverting the disable CL.

Comment 8 by asvitk...@chromium.org, Aug 13 2016

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/574fe529a9e808c41489f6b2acf6c9b835e90e8e

commit 574fe529a9e808c41489f6b2acf6c9b835e90e8e
Author: asvitkine <asvitkine@chromium.org>
Date: Sat Aug 13 01:03:22 2016

Revert of Disable flaky MetricsServiceBrowserTest#CloseRenderersNormally. (patchset #1 id:1 of https://codereview.chromium.org/2231443003/ )

Reason for revert:
Re-enabling test given the underlying issue has been fixed.

Original issue's description:
> Disable flaky MetricsServiceBrowserTest#CloseRenderersNormally.
>
> BUG= 636052 
> TBR=asvitkine@chromium.org
>
> Committed: https://crrev.com/f0b0de291ba041ed4bb40a0e3ead7d8324acdd49
> Cr-Commit-Position: refs/heads/master@{#410830}

TBR=esprehn@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 636052 

Review-Url: https://codereview.chromium.org/2241073002
Cr-Commit-Position: refs/heads/master@{#411840}

[modify] https://crrev.com/574fe529a9e808c41489f6b2acf6c9b835e90e8e/chrome/browser/metrics/metrics_service_browsertest.cc
►

Sign in to add a comment