New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636045 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

site settings menu items not working

Project Member Reported by dschuyler@chromium.org, Aug 9 2016

Issue description

Open site settings and go into a category (such as Cookies).
Select an item from the dropdown menu in an Allow or Block row.
Nothing happens (though an error about 'origin' is printed on the console.
 
Cc: kamakshi@chromium.org jansson@chromium.org ranjitkan@chromium.org kjellander@chromium.org dschuyler@chromium.org nyerramilli@chromium.org hbos@chromium.org
 Issue 636233  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e44460d32499881c1c18830202f5b6f1ccebe96

commit 4e44460d32499881c1c18830202f5b6f1ccebe96
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Aug 12 02:18:58 2016

[MD settings] setup site settings menus

This CL gets the site settings dropdown menus working again and adds a
unit test to help detect the issue in the future.

BUG= 636045 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2230513003
Cr-Commit-Position: refs/heads/master@{#411522}

[modify] https://crrev.com/4e44460d32499881c1c18830202f5b6f1ccebe96/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/4e44460d32499881c1c18830202f5b6f1ccebe96/chrome/test/data/webui/settings/site_list_tests.js

Status: Fixed (was: Started)
Looks good in M54 Canary 54.0.2829.0 in Win, Mac - in  chrome://settings/siteSettings, site cookies/permissions can be changed 

Sign in to add a comment