Incorrect sync error placement and size in user menu button |
||
Issue descriptionUntil the md updates are made in crbug.com/590917 , the sync error icon needs a few adjustments: 1. The icon should be displayed at 16px. It's currently <16px which is leading to some unwanted pixelation at 1x 2. The icon should be displayed to the left of the name, not the right.
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19be3524dfeed25a8ef1e65fdd380f7a6ed1914f commit 19be3524dfeed25a8ef1e65fdd380f7a6ed1914f Author: janeliulwq <janeliulwq@google.com> Date: Fri Aug 12 17:24:59 2016 [MD User Menu] Adjusted the size and position of avatar button icon 1. Adjusted the size of the error icon in the avatar button to be 16 2. On mac, moved the icon from the RHS to LHS BUG= 636037 Review-Url: https://codereview.chromium.org/2237023002 Cr-Commit-Position: refs/heads/master@{#411688} [modify] https://crrev.com/19be3524dfeed25a8ef1e65fdd380f7a6ed1914f/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm [modify] https://crrev.com/19be3524dfeed25a8ef1e65fdd380f7a6ed1914f/chrome/browser/ui/views/profiles/new_avatar_button.cc
,
Aug 12 2016
The CL above addresses both the size and the position issue.
,
Aug 15 2016
Disregard my last comment, just say your update on Issue 636035
,
Aug 15 2016
Icon displayed on the LHS LGTM. Let's forward the remainder of the discussion to Issue 636035 |
||
►
Sign in to add a comment |
||
Comment 1 by ew...@chromium.org
, Aug 9 2016Labels: md-usermenu
Owner: rogerta@chromium.org