Sync error icon misaligned in user menu button |
|||
Issue descriptionExpected: Icon is 2px too high. See attachment
,
Aug 9 2016
And how about Linux? Thanks!
,
Aug 9 2016
,
Aug 9 2016
Here's the Mac one, for reference. It looks to me like it applies to Mac as well, but I'll let Alan comment.
,
Aug 9 2016
Hi Alan, just a heads up that the current size of the sync error icon is actually 13px across all platforms. I'm assuming I need to update it to be 16px then. The question now is just how much adjustment is needed on windows, linux, and mac respectively. Thanks!
,
Aug 12 2016
Alan, now that I landed a CL to make the error icon 16px, it seems to me that the icon looks a tiny little less off-centered on mac. So, how much adjustment do we want for each platform? It looks to me that Linux doesn't need any adjustment, whereas Windows and Mac could have a 1 or 2px adjustment. What do you think?
,
Aug 15 2016
Thanks Jane. For Mac, it doesn't seem like the 16x16 icon is vertically centered within the menu so are the 1px adjustments to the icon or the user name text? Generally, I don't what is adjusted, so as long as the final outcome produces both elements to be vertically centered. For windows/linux, those screenshots LGTM.
,
Aug 16 2016
Talking with Jane, we're bumping the icon down 1px for MAC.
,
Aug 23 2016
Mac screenshot LGTM
,
Aug 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c21870f967d30e6bd32c1e9c55e82f345a94d53 commit 3c21870f967d30e6bd32c1e9c55e82f345a94d53 Author: janeliulwq <janeliulwq@google.com> Date: Wed Aug 24 01:04:35 2016 [Mac][MD User Menu] Adjusted the vertical position of icon in avatar button Adjusted the vertical position of the error icon in MD avatar button so that it looks vertically centered. See first bug. BUG= 636035 BUG= 615893 Review-Url: https://codereview.chromium.org/2268393002 Cr-Commit-Position: refs/heads/master@{#413918} [modify] https://crrev.com/3c21870f967d30e6bd32c1e9c55e82f345a94d53/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
,
Aug 24 2016
The CL above brings down the mac icon by 1px. The icon should be aligned on all platforms now.
,
Aug 24 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by janeliulwq@google.com
, Aug 9 2016