New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636031 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Aug 2016
Cc:
dpranke@chromium.org
█ smut@chromium.org
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS , Mac
Pri: 3
Type: Bug



Sign in to add a comment

iOS bots should force a clobber if Xcode version changes

Project Member Reported by sdefresne@chromium.org, Aug 9 2016 
If the version of Xcode used change (as selected in bot .json file via "xcode version") then the bot should force a clobber as gn may not be smart enough to realise some key piece of the infrastructure changed and requires to rebuild everything.

We can probably reuse the code that detected switching between gyp & gn.

Comment 1 by dpranke@chromium.org, Aug 9 2016 

For changes to versions of clang, we set a dummy #define on the command line to the clang version, and that has the net effect of forcing everything to recompile. We should probably do something similar for xcode sdk versions (and windows sdk versions; there's a separate open bug for that).

We don't want to re-use the gyp/gn logic because that depended on MB being run, which we don't really want to depend on if we can avoid it.

Comment 2 by sdefresne@chromium.org, Aug 9 2016

Labels: -OS-iOS OS-All
Good idea, https://codereview.chromium.org/2228143002/ should do this for mac/iOS.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64cd47fc5002365b42d3abe6d8381f5bb0dfcae1

commit 64cd47fc5002365b42d3abe6d8381f5bb0dfcae1
Author: sdefresne <sdefresne@chromium.org>
Date: Fri Aug 12 00:48:54 2016

Force rebuild of everything if the version of Xcode changes.

BUG= 636031 

Review-Url: https://codereview.chromium.org/2228143002
Cr-Commit-Position: refs/heads/master@{#411491}

[modify] https://crrev.com/64cd47fc5002365b42d3abe6d8381f5bb0dfcae1/build/config/mac/BUILD.gn

Comment 4 by sdefresne@chromium.org, Aug 12 2016

Labels: -OS-All OS-iOS OS-Mac
Status: Fixed (was: Untriaged)
►

Sign in to add a comment