New issue
Advanced search Search tips

Issue 636010 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 615155



Sign in to add a comment

mash shelf: Create ShelfWindowTargeter equivalent for mus

Project Member Reported by jamescook@chromium.org, Aug 9 2016

Issue description

ash::ShelfWindowTargeter makes it easier to resize browser windows that sit directly on top of the shelf. It does this by insetting the shelf and status area container aura::Windows by 2 pixels.

Since this is changing event targeting we'll need a different approach for mus. Maybe we can roll it into the existing ui::ws::ServerWindow::extended_hit_test_region_
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/752e8df8664956328150560c93c13e3c00a6987f

commit 752e8df8664956328150560c93c13e3c00a6987f
Author: jamescook <jamescook@chromium.org>
Date: Tue Aug 09 19:54:39 2016

ash: Move ShelfWindowTargeter construction from ShelfWidget to RootWindowController

This eliminates aura::Window dependencies from ShelfWidget, which we need to do
to get it running in mus/mash.

mus will need a different implementation of this feature.

BUG= 615155 , 636010 
TEST=existing ash_unittests for ShelfWidget

Review-Url: https://codereview.chromium.org/2222093003
Cr-Commit-Position: refs/heads/master@{#410781}

[modify] https://crrev.com/752e8df8664956328150560c93c13e3c00a6987f/ash/root_window_controller.cc
[modify] https://crrev.com/752e8df8664956328150560c93c13e3c00a6987f/ash/shelf/shelf_widget.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/752e8df8664956328150560c93c13e3c00a6987f

commit 752e8df8664956328150560c93c13e3c00a6987f
Author: jamescook <jamescook@chromium.org>
Date: Tue Aug 09 19:54:39 2016

ash: Move ShelfWindowTargeter construction from ShelfWidget to RootWindowController

This eliminates aura::Window dependencies from ShelfWidget, which we need to do
to get it running in mus/mash.

mus will need a different implementation of this feature.

BUG= 615155 , 636010 
TEST=existing ash_unittests for ShelfWidget

Review-Url: https://codereview.chromium.org/2222093003
Cr-Commit-Position: refs/heads/master@{#410781}

[modify] https://crrev.com/752e8df8664956328150560c93c13e3c00a6987f/ash/root_window_controller.cc
[modify] https://crrev.com/752e8df8664956328150560c93c13e3c00a6987f/ash/shelf/shelf_widget.cc

Labels: Proj-Mustash-Mus-WS Proj-Mustash-Mash
Labels: Proj-Mustash
Components: Internals>MUS
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Labels: -Proj-Mustash-Mus-WS
Deprecating Proj-Mustash-Mus-WS label in favor of Components.
Status: Fixed (was: Untriaged)
Fixed by WS2.

Sign in to add a comment