New issue
Advanced search Search tips

Issue 635991 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 631199



Sign in to add a comment

Propagate duration changes from MediaPlayerRenderer

Project Member Reported by tguilbert@chromium.org, Aug 9 2016

Issue description

Currently, only the DemuxerHost interface allows the propagation of duration changes.

In the case of the MediaPlayerRenderer, all duration changes are detected on the browser side by the MediaPlayer.

This change tracks the addition of a "OnDurationChange()" to the RendererClient media and mojo interfaces.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc

commit 2875bf04f6a471d51491cb45fc3eefba7ae5e4fc
Author: tguilbert <tguilbert@chromium.org>
Date: Sat Aug 13 12:11:55 2016

Add OnDurationChange() to RenderClient

Currently, only the DemuxerHost interface allows the propragation of
duration changes; the demuxer is responsible for detecting duration
changes and notifying the Pipeline.

In the case of the MediaPlayerRenderer, we use a MediaUrlDemuxer, which
never receives duration updates. Instead, all metadata parsing happens
on the browser side, in the MediaPlayerRenderer. We therefore need a
way to propagate the duration changes from the MediaPlayerRenderer to
the pipeline.

This change adds an OnDurationChange method to both the
media::RendererClient and the mojom::RendererClient interfaces.

BUG= 635991 

Review-Url: https://codereview.chromium.org/2243683002
Cr-Commit-Position: refs/heads/master@{#411893}

[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/content/browser/media/android/media_player_renderer.cc
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/content/renderer/media/android/media_player_renderer_client.cc
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/content/renderer/media/android/media_player_renderer_client.h
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/base/mock_filters.h
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/base/pipeline_impl.cc
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/base/renderer_client.h
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/mojo/clients/mojo_renderer.cc
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/mojo/clients/mojo_renderer.h
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/mojo/interfaces/renderer.mojom
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/mojo/services/media_mojo_unittest.cc
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/mojo/services/mojo_renderer_service.cc
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/mojo/services/mojo_renderer_service.h
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/renderers/audio_renderer_impl_unittest.cc
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/renderers/renderer_impl.cc
[modify] https://crrev.com/2875bf04f6a471d51491cb45fc3eefba7ae5e4fc/media/renderers/renderer_impl_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment