New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635970 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Chrome shelf icon behaves unintuitively when popup window is open

Project Member Reported by derat@chromium.org, Aug 9 2016

Issue description

Google Chrome	52.0.2743.116 (Official Build) (32-bit)
Revision	9115ecad1cae66fd5fe52bd9120af643384fd6f3-refs/branch-heads/2743@{#728}
Platform	8350.68.0 (Official Build) stable-channel veyron_speedy

The behavior of the persistent "Chrome" icon that appears to the right of the search icon in the shelf feels confusing when you only have a popup window (e.g. for a video hangout) open.

1. Open a single browser window with Gmail in it.
2. Start a video hangout. A new hangouts.google.com popup window is opened.
3. Close the original browser window so only the Hangouts popup is open.

The Chrome icon has a white underline, but there's no normal browser window. (I'll note that you can hit Ctrl-T while the popup is focused to create a new browser window with a new tab, but this is unexpected and non-obvious to me.)

My impression of the Chrome icon is that it represents a "normal" browser window (which may contain hosted apps that were launched via other icons in the shelf), so it feels strange that it's active when only a popup is open (particularly one like a Hangouts video chat, which feels app-like to me).

More specifically, I hit Alt-1 when I want a browser window so I can visit a new page. When I do this while the Hangouts popup is open (since it doesn't look like a normal browser window), instead of getting a browser window that I can type into, the Hangouts popup is minimized and I'm left with an empty desktop.

Here's the weird thing: If I *click* on the Chrome icon instead of hitting Alt-1, I get a new browser window instead of the popup being minimized! So we actually do what I want, but only if I click the icon instead of using its accelerator.

To make this more concrete: I think we should make Alt-1 open a regular browser window when only a popup window is open and focused, instead of minimizing the popup.
 

Comment 1 by derat@chromium.org, Aug 9 2016

Cc: steve...@chromium.org
Labels: -Pri-3 M-52 Pri-2
I'm not familiar with this code, but cc-ing stevenjb@ since he's made changes to chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc which seems like it could be relevant.

Comment 2 by derat@chromium.org, Aug 9 2016

The clicking and accelerator behavior is also different is when opening a hosted app like Gmail or Calendar. Here, hitting either Alt-1 or Alt-[1-based-index of hosted app's icon] when the app's tab is already focused just bounces the browser window, but clicking either icon minimizes the browser window.

I understand that the click vs. accelerator behavior is different when multiple windows are open for the app (clicking displays a menu listing the windows), but these other differences feel confusing to me. I don't have a reliable mental model for what's going to happen when I click these icons or hit their accelerators, apart from in the case when I'm initially staring at an empty desktop. That seems bad. :-(
Owner: tbuck...@chromium.org
Status: Assigned (was: Untriaged)
tbuckley@ we should reconsider what the correct behavior is here as part of the MD shelf work.
Labels: -M-52 M-55
I agree that clicking and using an accelerator should be consistent at the very least.

Going to need to think more about this, but here are some initial thoughts:
1) I'd like to keep the invariant that every window is associated with an icon on the shelf. So for that hangout pop-up, the Chrome icon should be associated with it.
2) That being said, I agree that it's weird that clicking the Chrome icon could leave you in a state where no browser window is active. So maybe we can treat that as a special case?
3) Could we ensure that clicking an app icon in the shelf always focuses an existing window / launches a new window? How often are apps minimized through the shelf vs the window header?
Labels: Proj-MaterialDesign-CrOS
Labels: -M-55 M-56
Labels: -M-56
Labels: Hotlist-Poachable

Comment 9 by vadimt@chromium.org, Nov 29 2017

Labels: Not-Touch-Friendly-Launcher
Status: Available (was: Assigned)
What's the status of this? This bug hasn't been updated with a meaningful comment in ~2.5 years. Is this still relevant?
Cc: omrilio@chromium.org
Owner: ovanieva@chromium.org
Status: Untriaged (was: Available)
Yes, the shelf still doesn't behave consistently. At the very least, I think we need the following:

a) The behavior when clicking on an icon and typing its Alt+num accelerator should be consistent.
b) Clicking an icon (or activating it via its accelerator) should consistently focus the corresponding window/tab/app (opening it if needed) if it isn't already focused.
c) Clicking the icon when the window/tab/app is focused should possibly iconify it. I'm less sure about this (because when the icon corresponds to a tab in a browser window, it feels a bit weird to iconify the entire window), but it seems to be the behavior that we're trying to do right now.

Olga, are you the right person to be looking at this?
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
Owner: garykim@chromium.org
Thanks. Routing to Gary for UX input.

Sign in to add a comment