Screenshare tray icon is misaligned |
|||
Issue descriptionGoogle Chrome 52.0.2743.116 (Official Build) (32-bit) Revision 9115ecad1cae66fd5fe52bd9120af643384fd6f3-refs/branch-heads/2743@{#728} Platform 8350.68.0 (Official Build) stable-channel veyron_speedy The "screenshare" icon in the status area / system tray, displayed when using the Cast extension, is misaligned and doesn't match the other icons. There are light and dark versions of the icon at the following locations: ash/resources/default_100_percent/cros/status/status_screenshare.png ash/resources/default_100_percent/cros/status/status_screenshare_dark.png ash/resources/default_200_percent/cros/status/status_screenshare.png ash/resources/default_200_percent/cros/status/status_screenshare_dark.png I think that there are multiple problems here: - The "screen" part of the icon is too wide within its 25x25 bounds. The update icon (attached) leaves ~5 pixels of padding on either part of its filled area, while the screenshare icon only leaves 3. Even the update icon looks a bit too wide, though. - The non-dark icon may be a bit too opaque, particularly in terms of its shadow. The other icons I looked at had opaque white regions as well, though, so it might just look heavy because so much of it is white. - Something is wrong in the code that's vertically aligning this icon; it's placing it too high. I haven't dug deeply enough into the system tray code to figure out where the problem is, but I note that other classes like TrayUpdate derive from TrayImageItem. Maybe that should be used here too (although it's also possible I'm misunderstanding the class hierarchy, because all of this is a soup of the words "tray", "item", "status", and "view" to me... :-P). It's possible that we just want to hold off on dealing with this until things get changed around for MD, but I figured I'd file a bug since it looks pretty jarring.
,
Aug 9 2016
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01746c493874c68d66969911d2a1bda71cb57002 commit 01746c493874c68d66969911d2a1bda71cb57002 Author: tdanderson <tdanderson@chromium.org> Date: Tue Aug 09 17:12:52 2016 Fix horizontal and vertical padding for Cast icon in Ash system tray The horizontal and vertical padding values for the Cast icon in the Ash system tray are incorrectly reversed. Use horizontal padding for a horizontal shelf and use vertical padding for a vertical shelf. BUG= 635955 TEST=manual Review-Url: https://codereview.chromium.org/2223263003 Cr-Commit-Position: refs/heads/master@{#410718} [modify] https://crrev.com/01746c493874c68d66969911d2a1bda71cb57002/ash/common/system/cast/tray_cast.cc
,
Aug 9 2016
CL landed in M-54. Waiting to verify on canary before requesting a merge back into M-53.
,
Sep 21 2016
Sorry, looks like this bug fell off my radar, and we are well past the branch point for M-53. I don't think this is critical enough to justify a merge into 53 stable (someone cc'ed feel free to disagree) so I will keep this as fixed in 54.
,
Oct 19 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tdander...@chromium.org
, Aug 9 2016Status: Started (was: Untriaged)