New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635955 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Screenshare tray icon is misaligned

Project Member Reported by derat@chromium.org, Aug 9 2016

Issue description

Google Chrome	52.0.2743.116 (Official Build) (32-bit)
Revision	9115ecad1cae66fd5fe52bd9120af643384fd6f3-refs/branch-heads/2743@{#728}
Platform	8350.68.0 (Official Build) stable-channel veyron_speedy

The "screenshare" icon in the status area / system tray, displayed when using the Cast extension, is misaligned and doesn't match the other icons. There are light and dark versions of the icon at the following locations:

ash/resources/default_100_percent/cros/status/status_screenshare.png
ash/resources/default_100_percent/cros/status/status_screenshare_dark.png
ash/resources/default_200_percent/cros/status/status_screenshare.png
ash/resources/default_200_percent/cros/status/status_screenshare_dark.png

I think that there are multiple problems here:

- The "screen" part of the icon is too wide within its 25x25 bounds. The update icon (attached) leaves ~5 pixels of padding on either part of its filled area, while the screenshare icon only leaves 3. Even the update icon looks a bit too wide, though.

- The non-dark icon may be a bit too opaque, particularly in terms of its shadow. The other icons I looked at had opaque white regions as well, though, so it might just look heavy because so much of it is white.

- Something is wrong in the code that's vertically aligning this icon; it's placing it too high. I haven't dug deeply enough into the system tray code to figure out where the problem is, but I note that other classes like TrayUpdate derive from TrayImageItem. Maybe that should be used here too (although it's also possible I'm misunderstanding the class hierarchy, because all of this is a soup of the words "tray", "item", "status", and "view" to me... :-P).

It's possible that we just want to hold off on dealing with this until things get changed around for MD, but I figured I'd file a bug since it looks pretty jarring.
 
Screenshot 2016-08-08 at 21.28.52.png
8.2 KB View Download
status_screenshare_100.png
227 bytes View Download
status_screenshare_dark_100.png
174 bytes View Download
status_update_100.png
294 bytes View Download
status_update_dark_100.png
287 bytes View Download
Owner: tdander...@chromium.org
Status: Started (was: Untriaged)
Great timing - I found this bug and started fixing it moments before you filed this bug :)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01746c493874c68d66969911d2a1bda71cb57002

commit 01746c493874c68d66969911d2a1bda71cb57002
Author: tdanderson <tdanderson@chromium.org>
Date: Tue Aug 09 17:12:52 2016

Fix horizontal and vertical padding for Cast icon in Ash system tray

The horizontal and vertical padding values for the Cast
icon in the Ash system tray are incorrectly reversed.
Use horizontal padding for a horizontal shelf and
use vertical padding for a vertical shelf.

BUG= 635955 
TEST=manual

Review-Url: https://codereview.chromium.org/2223263003
Cr-Commit-Position: refs/heads/master@{#410718}

[modify] https://crrev.com/01746c493874c68d66969911d2a1bda71cb57002/ash/common/system/cast/tray_cast.cc

CL landed in M-54. Waiting to verify on canary before requesting a merge back into M-53. 
Labels: -M-52 M-54
Status: Fixed (was: Started)
Sorry, looks like this bug fell off my radar, and we are well past the branch point for M-53. I don't think this is critical enough to justify a merge into 53 stable (someone cc'ed feel free to disagree) so I will keep this as fixed in 54.
Status: Verified (was: Fixed)

Sign in to add a comment