Issue metadata
Sign in to add a comment
|
10.3%-53% regression in blink_perf.pywebsocket at 410454:410479 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 9 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9004790783438654080
,
Aug 9 2016
=== Auto-CCing suspected CL author darin@chromium.org === Hi darin@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert "Port WebSockets to Mojo IPC" Author : darin Commit description: This reverts commit 2b78d9ee821f4d5c8c31a05028360610f5d0069f due to memory corruption issues. TBR=jam@chromium.org,tsepez@chromium.org BUG=635397, 635602 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2225133002 Cr-Commit-Position: refs/heads/master@{#410456} Commit : 815c4cbb961e3c077f96b084cd00737f82035da3 Date : Mon Aug 08 21:09:03 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@410453 33.9 0.777817 5 good chromium@410455 33.52 0.973139 5 good chromium@410456 44.34 1.32212 5 bad <-- chromium@410459 44.82 1.84581 5 bad chromium@410464 43.16 0.371484 5 bad chromium@410475 43.98 0.798123 5 bad Bisect job ran on: linux_perf_bisect Bug ID: 635954 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.pywebsocket Test Metric: WebSocket-receive-window-async-verify/WebSocket-receive-window-async-verify Relative Change: 29.73% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6631 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004790783438654080 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5031705497305088 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Aug 9 2016
The offending change has been reverted. Thanks for the bug report. I'll make sure to address this regression before I attempt to land the CL again.
,
Aug 9 2016
Oh, disregard that last comment. What happened here is that my original CL actually improved performance, but I had to revert it due to memory corruption issues. There is no net change in performance if you look back far enough. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by rmcilroy@chromium.org
, Aug 9 2016