We'll have to support older backends in the modern frontend once it gets deployed in other binaries.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c000dbd6fbdf95e745f907540aa43e6be20ecec commit 1c000dbd6fbdf95e745f907540aa43e6be20ecec Author: dgozman <dgozman@chromium.org> Date: Mon Aug 22 22:43:08 2016 [DevTools] Schema domain implementation. One can query domain names and versions. v8_inspector provides it's own implementation, while browser has a hardcoded list for now. BUG= 635947 , 635953 Review-Url: https://codereview.chromium.org/2253383002 Cr-Commit-Position: refs/heads/master@{#413561} [add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/protocol/schema_handler.cc [add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/protocol/schema_handler.h [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/worker_devtools_agent_host.cc [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/worker_devtools_agent_host.h [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/content_browser.gypi [add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents-expected.txt [add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents.html [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/blink_platform.gyp [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/blink_platform.gypi [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h [add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/V8SchemaAgentImpl.cpp [add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/V8SchemaAgentImpl.h [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h [modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d99d907ee8cc3450c02c607125bb24f5d313fb97 commit d99d907ee8cc3450c02c607125bb24f5d313fb97 Author: dgozman <dgozman@chromium.org> Date: Fri Nov 04 06:03:03 2016 [DevTools] Remove handlers = browser from protocol definition. Content generator is now aware of the methods it should generate. Same will be done for blink generator in next patch. BUG= 635953 Review-Url: https://codereview.chromium.org/2478703002 Cr-Commit-Position: refs/heads/master@{#429807} [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/chrome/browser/devtools/devtools_protocol_constants_generator.py [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/content/browser/devtools/protocol/devtools_protocol_handler_generator.py [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/content/browser/devtools/protocol/emulation_handler.cc [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/content/browser/devtools/protocol/emulation_handler.h [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/content/browser/devtools/protocol/input_handler.cc [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/content/browser/devtools/protocol/input_handler.h [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/content/browser/devtools/protocol/memory_handler.cc [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/content/browser/devtools/protocol/memory_handler.h [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/content/browser/devtools/protocol/page_handler.cc [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/content/browser/devtools/protocol/page_handler.h [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/third_party/WebKit/LayoutTests/inspector/report-protocol-errors-expected.txt [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/third_party/WebKit/LayoutTests/inspector/report-protocol-errors.html [modify] https://crrev.com/d99d907ee8cc3450c02c607125bb24f5d313fb97/third_party/WebKit/Source/core/inspector/browser_protocol.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/262e483fc7532d8b7e24c7ef40c53ad4dee94f9a commit 262e483fc7532d8b7e24c7ef40c53ad4dee94f9a Author: dgozman <dgozman@chromium.org> Date: Mon Nov 07 21:53:02 2016 [DevTools] Roll third_party/inspector_protocol to 3c6f5ff8ab6653b47cf226233d488701a527d761. Roll includes: - Add missing virtual destructor to backend callbacks. - Support config.protocol.options which defines which part of protocol definition should be generated. Additional changes: - Removed handlers = renderer and async information from protocol. - Added handlers/async information to inspector_protocol_config.json. - Added handlers/async information to generator in content/browser. BUG= 635953 Review-Url: https://codereview.chromium.org/2475663004 Cr-Commit-Position: refs/heads/master@{#430387} [modify] https://crrev.com/262e483fc7532d8b7e24c7ef40c53ad4dee94f9a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py [modify] https://crrev.com/262e483fc7532d8b7e24c7ef40c53ad4dee94f9a/third_party/WebKit/Source/core/inspector/browser_protocol.json [modify] https://crrev.com/262e483fc7532d8b7e24c7ef40c53ad4dee94f9a/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json [modify] https://crrev.com/262e483fc7532d8b7e24c7ef40c53ad4dee94f9a/third_party/inspector_protocol/CodeGenerator.py [modify] https://crrev.com/262e483fc7532d8b7e24c7ef40c53ad4dee94f9a/third_party/inspector_protocol/README.chromium [modify] https://crrev.com/262e483fc7532d8b7e24c7ef40c53ad4dee94f9a/third_party/inspector_protocol/templates/TypeBuilder_cpp.template [modify] https://crrev.com/262e483fc7532d8b7e24c7ef40c53ad4dee94f9a/third_party/inspector_protocol/templates/TypeBuilder_h.template
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bd45cc451e96d464522185ef1e946f094442f4b commit 8bd45cc451e96d464522185ef1e946f094442f4b Author: dgozman <dgozman@chromium.org> Date: Thu Nov 10 01:05:59 2016 [DevTools] Roll third_party/inspector_protocol to e23134c5aa6131e5a3a3afbefce255becce3a3bd. This includes: - [inspector_protocol] Allow custom json parser. - [inspector_protocol] Allow overriding specific config values. - [inspector_protocol] Fix NoneType error when parsing config_values. BUG= 635953 Review-Url: https://codereview.chromium.org/2490473004 Cr-Commit-Position: refs/heads/master@{#431123} [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/components/ui_devtools/BUILD.gn [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/components/ui_devtools/devtools_client.cc [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/components/ui_devtools/inspector_protocol_config.json [delete] https://crrev.com/851bdd47fcb66176959020a63bbdb3b4b090d845/components/ui_devtools/protocol_platform.h [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/components/ui_devtools/string_util.cc [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/components/ui_devtools/string_util.h [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/WebKit/Source/core/inspector/BUILD.gn [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/WebKit/Source/core/inspector/InspectorSession.cpp [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/WebKit/Source/core/inspector/ProtocolParserTest.cpp [delete] https://crrev.com/851bdd47fcb66176959020a63bbdb3b4b090d845/third_party/WebKit/Source/core/inspector/ProtocolPlatform.h [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/WebKit/Source/core/inspector/V8InspectorString.cpp [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/WebKit/Source/core/inspector/V8InspectorString.h [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/inspector_protocol/CodeGenerator.py [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/inspector_protocol/README.chromium [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/inspector_protocol/inspector_protocol.gni [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/inspector_protocol/lib/Array_h.template [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/inspector_protocol/lib/DispatcherBase_cpp.template [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/inspector_protocol/lib/Forward_h.template [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/inspector_protocol/lib/Object_cpp.template [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/inspector_protocol/lib/Parser_cpp.template [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/inspector_protocol/lib/Parser_h.template [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/inspector_protocol/lib/Values_h.template [modify] https://crrev.com/8bd45cc451e96d464522185ef1e946f094442f4b/third_party/inspector_protocol/templates/TypeBuilder_cpp.template
We are looking for real use cases to figured out good solution here. For now I am closing this one.
Comment 1 by dgozman@chromium.org
, Aug 9 2016