Found the following details to sort out after merge:
- run inspector_protocol tests in v8;
- expose location of js_protocol.json in v8's BUILD files;
- move injected and debugger scripts compilation to v8;
- figure out frontend compilation based on js_protocol (either expose it from v8, remove or commit to blink);
- fix compilation warning in src/inspector and remove build flags;
- reformat the code to follow v8 style.
Does this mean it's ready to go? gn builds on mac aren't very happy, though. If it's ready for use (or at least outside testing), is there any way to build with gyp?
@xaxxon: what do you mean by gn builds on mac? Are those Chromium builds?
v8-inspector is definitely ready for use, although we may tweak API slightly based on early feedback from integration with clients.
There is a way to build with gyp:\
./gypfiles/gyp_v8 -Dv8_enable_inspector=1
> v8-inspector is definitely ready for use,
Just to be very clear, v8-inspector is something to allow an application with embedded v8 to be debugged via the chrome debugging protocol -- like with the inspector.js javascript debugger build in to chrome, right?
I've already implemented a minimally functional implementation for my application, so I have an understanding of what's going on under the hood, but just looking at your class types in doxygen I don't see anything that jumps out at me as a starting point. Can you either point me at a few things to use to piece together the first bits or some example code/tests that can give me a jump start down the right path?
Thank you.
You could take a look at v8/test/inspector/inspector-test.cc to see how it's hooked up. I also have a CL pending that adds inspector support to d8 here: https://codereview.chromium.org/2425973002/
I think I'm missing something fundamental. Is it mostly implemented in javascript? Where is the websocket set up? am I thinking about what v8-inspector is all wrong?
V8 inspector only deals with parsing and responding via JSON protocol. Sending and receiving these strings via socket has to be implemented by embedder.
Comment 1 by dgozman@chromium.org
, Aug 9 2016