New issue
Advanced search Search tips

Issue 635947 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 591496
issue 623763
issue 632875
issue 635953

Blocking:
issue 635948



Sign in to add a comment

DevTools: js protocol version 1.2

Project Member Reported by dgozman@chromium.org, Aug 9 2016

Issue description

We should cleanup protocol and expose most of it as version 1.2.
 
Blockedon: 591496 623763 632875
Blocking: 635948
Blockedon: 635953
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/598cc67904b638978bed91f7c859067c5c11712a

commit 598cc67904b638978bed91f7c859067c5c11712a
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Aug 11 01:38:30 2016

[DevTools] Removed interstatementLocation from Debugger.continueToLocation

BUG= 635947 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2239473003
Cr-Commit-Position: refs/heads/master@{#411218}

[modify] https://crrev.com/598cc67904b638978bed91f7c859067c5c11712a/third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation-expected.txt
[modify] https://crrev.com/598cc67904b638978bed91f7c859067c5c11712a/third_party/WebKit/LayoutTests/inspector-protocol/debugger/continueToLocation.html
[modify] https://crrev.com/598cc67904b638978bed91f7c859067c5c11712a/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js
[modify] https://crrev.com/598cc67904b638978bed91f7c859067c5c11712a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
[modify] https://crrev.com/598cc67904b638978bed91f7c859067c5c11712a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h
[modify] https://crrev.com/598cc67904b638978bed91f7c859067c5c11712a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/598cc67904b638978bed91f7c859067c5c11712a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
[modify] https://crrev.com/598cc67904b638978bed91f7c859067c5c11712a/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edd943d7d9ff10541153e7021ea4645cf35bdd8a

commit edd943d7d9ff10541153e7021ea4645cf35bdd8a
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Aug 12 23:25:54 2016

[DevTools] Removed wasThrown from evaluate-like protocol methods

I'll remove this flag from frontend in followup.
Clients can emulate wasThrown flag with !!exceptionDetails check.

BUG= 635947 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2234983002
Cr-Commit-Position: refs/heads/master@{#411814}

[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/injected-script-discard.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/reattach-after-editing-styles.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-restart.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/access-inspected-object.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/console/console-memory-setter-in-strict-mode-expected.txt
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/json-parse-expected.txt
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise-expected.txt
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async-expected.txt
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-clear-of-command-line-api-expected.txt
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async-expected.txt
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-in-default-context-expected.txt
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-get-properties-on-proxy-expected.txt
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-property-on-console-proto-expected.txt
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async-expected.txt
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/console/console-tainted-globals.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/console/inspect-html-all-collection.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/elements/resolve-alien-node.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/elements/resolve-node-blocked.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/local-object.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/runtime/runtime-es6-setSymbolPropertyValue.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/runtime/runtime-setPropertyValue.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-save-to-temp-var.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/edd943d7d9ff10541153e7021ea4645cf35bdd8a/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf48b95307f9c3a066e4e3f882094bf577dfdab7

commit bf48b95307f9c3a066e4e3f882094bf577dfdab7
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Sat Aug 13 03:23:45 2016

[DevTools] Simplify evaluation callbacks on frontend

BUG= 635947 
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2236033002
Cr-Commit-Position: refs/heads/master@{#411869}

[modify] https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
[modify] https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/bf48b95307f9c3a066e4e3f882094bf577dfdab7/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95929275dd905ef99458b5fb2838bef497df8708

commit 95929275dd905ef99458b5fb2838bef497df8708
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Sat Aug 13 07:43:24 2016

[DevTools] Removed isInternalScript flag from protocol

Internal scripts in DevTools:
- InjectedScriptSource.js,
- DebuggerScript.js,
- callFunctionOn uses internal script to compile function declaration and call arguments.

We can ignore these scripts, not report them to frontend and never stop in them since they are a part of debugger implementation.

BUG= 635947 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2247483003
Cr-Commit-Position: refs/heads/master@{#411886}

[modify] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
[add] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/LayoutTests/inspector/sources/debugger/dont-report-injected-script-expected.txt
[rename] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/LayoutTests/inspector/sources/debugger/dont-report-injected-script.html
[delete] https://crrev.com/893311650c65a738a6b9d1921a9d485772c37a72/third_party/WebKit/LayoutTests/inspector/sources/debugger/internal-script-flag-for-injected-script-expected.txt
[modify] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/Source/devtools/front_end/sdk/Script.js
[modify] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js
[modify] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js
[modify] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
[modify] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp
[modify] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h
[modify] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/Source/platform/v8_inspector/debugger_script_externs.js
[modify] https://crrev.com/95929275dd905ef99458b5fb2838bef497df8708/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/816474328ff9b737dffbe733c0d7b2c286151ffb

commit 816474328ff9b737dffbe733c0d7b2c286151ffb
Author: dgozman <dgozman@chromium.org>
Date: Mon Aug 15 20:56:28 2016

[DevTools] Rename entities in js_protocol, remove deprecated ones.

BUG= 635947 

Review-Url: https://codereview.chromium.org/2249743002
Cr-Commit-Position: refs/heads/master@{#412043}

[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/LayoutTests/inspector-protocol/debugger/suspend-setTimeout-on-pause-in-dedicated-worker.html
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
[modify] https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba330db4823510f9e2b5c1224883e919f372f4da

commit ba330db4823510f9e2b5c1224883e919f372f4da
Author: bsep <bsep@chromium.org>
Date: Mon Aug 15 21:32:41 2016

Revert of [DevTools] Rename entities in js_protocol, remove deprecated ones. (patchset #1 id:1 of https://codereview.chromium.org/2249743002/ )

Reason for revert:
Compile failed on Linux ChromiumOS GN https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/44080

../../headless/lib/headless_devtools_client_browsertest.cc:177:56: error: no member named 'Run' in 'headless::runtime::ExperimentalDomain'
    devtools_client_->GetRuntime()->GetExperimental()->Run(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ^
../../headless/lib/headless_devtools_client_browsertest.cc:178:18: error: no member named 'RunParams' in namespace 'headless::runtime'
        runtime::RunParams::Builder().Build());
        ~~~~~~~~~^

Original issue's description:
> [DevTools] Rename entities in js_protocol, remove deprecated ones.
>
> BUG= 635947 
>
> Committed: https://crrev.com/816474328ff9b737dffbe733c0d7b2c286151ffb
> Cr-Commit-Position: refs/heads/master@{#412043}

TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 635947 

Review-Url: https://codereview.chromium.org/2249663003
Cr-Commit-Position: refs/heads/master@{#412052}

[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/LayoutTests/inspector-protocol/debugger/suspend-setTimeout-on-pause-in-dedicated-worker.html
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
[modify] https://crrev.com/ba330db4823510f9e2b5c1224883e919f372f4da/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2846fc559943461bfbfd2048b9b6e2665d0ea821

commit 2846fc559943461bfbfd2048b9b6e2665d0ea821
Author: dgozman <dgozman@chromium.org>
Date: Tue Aug 16 22:49:00 2016

[DevTools] Rename entities in js_protocol, remove deprecated ones.

BUG= 635947 

Review-Url: https://codereview.chromium.org/2249743002
Cr-Commit-Position: refs/heads/master@{#412364}

[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-step-into-dedicated-worker.html
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/LayoutTests/inspector-protocol/debugger/suspend-setTimeout-on-pause-in-dedicated-worker.html
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
[modify] https://crrev.com/2846fc559943461bfbfd2048b9b6e2665d0ea821/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30bce6e3d351554a14c1d64568979b25802ee6e0

commit 30bce6e3d351554a14c1d64568979b25802ee6e0
Author: dgozman <dgozman@chromium.org>
Date: Thu Aug 18 03:56:20 2016

[DevTools] Fill ExceptionDetails with more details, unify usage across protocol.

BUG= 635947 

Review-Url: https://codereview.chromium.org/2249743006
Cr-Commit-Position: refs/heads/master@{#412729}

[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/sdk/Script.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 18 2016

Labels: merge-merged-2832
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30bce6e3d351554a14c1d64568979b25802ee6e0

commit 30bce6e3d351554a14c1d64568979b25802ee6e0
Author: dgozman <dgozman@chromium.org>
Date: Thu Aug 18 03:56:20 2016

[DevTools] Fill ExceptionDetails with more details, unify usage across protocol.

BUG= 635947 

Review-Url: https://codereview.chromium.org/2249743006
Cr-Commit-Position: refs/heads/master@{#412729}

[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run-expected.txt
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/sdk/Script.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68666c0876081db75338384d7b76f0b5fb84473e

commit 68666c0876081db75338384d7b76f0b5fb84473e
Author: alph <alph@chromium.org>
Date: Sat Aug 20 10:26:16 2016

DevTools: Profiler domain refactoring: encode timestamps as deltas.

The CL makes CPUProfile encode sample timestamps as deltas, which makes the
representation more compact.
startTime and endTime are represented in microseconds rather than seconds.

BUG= 635947 

Review-Url: https://codereview.chromium.org/2262543002
Cr-Commit-Position: refs/heads/master@{#413332}

[modify] https://crrev.com/68666c0876081db75338384d7b76f0b5fb84473e/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-bottom-up-large-tree-search.html
[modify] https://crrev.com/68666c0876081db75338384d7b76f0b5fb84473e/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-bottom-up-times.html
[modify] https://crrev.com/68666c0876081db75338384d7b76f0b5fb84473e/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-flame-chart-overview.html
[modify] https://crrev.com/68666c0876081db75338384d7b76f0b5fb84473e/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-js-line-level-profile.html
[modify] https://crrev.com/68666c0876081db75338384d7b76f0b5fb84473e/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html
[modify] https://crrev.com/68666c0876081db75338384d7b76f0b5fb84473e/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
[modify] https://crrev.com/68666c0876081db75338384d7b76f0b5fb84473e/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
[modify] https://crrev.com/68666c0876081db75338384d7b76f0b5fb84473e/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c000dbd6fbdf95e745f907540aa43e6be20ecec

commit 1c000dbd6fbdf95e745f907540aa43e6be20ecec
Author: dgozman <dgozman@chromium.org>
Date: Mon Aug 22 22:43:08 2016

[DevTools] Schema domain implementation.

One can query domain names and versions.
v8_inspector provides it's own implementation, while browser has a hardcoded list for now.

BUG= 635947 , 635953 

Review-Url: https://codereview.chromium.org/2253383002
Cr-Commit-Position: refs/heads/master@{#413561}

[add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/protocol/schema_handler.cc
[add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/protocol/schema_handler.h
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/worker_devtools_agent_host.cc
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/browser/devtools/worker_devtools_agent_host.h
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/content/content_browser.gypi
[add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents-expected.txt
[add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents.html
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/blink_platform.gyp
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
[add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/V8SchemaAgentImpl.cpp
[add] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/V8SchemaAgentImpl.h
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
[modify] https://crrev.com/1c000dbd6fbdf95e745f907540aa43e6be20ecec/third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7358341b5ef6110ff7fedaf3cb5f978deb379ae

commit b7358341b5ef6110ff7fedaf3cb5f978deb379ae
Author: alph <alph@chromium.org>
Date: Mon Aug 22 23:31:08 2016

DevTooos: Profiler domain refactoring: Make deoptReason and positionTicks fields optional.

BUG= 635947 

Review-Url: https://codereview.chromium.org/2262303002
Cr-Commit-Position: refs/heads/master@{#413580}

[modify] https://crrev.com/b7358341b5ef6110ff7fedaf3cb5f978deb379ae/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js
[modify] https://crrev.com/b7358341b5ef6110ff7fedaf3cb5f978deb379ae/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
[modify] https://crrev.com/b7358341b5ef6110ff7fedaf3cb5f978deb379ae/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js
[modify] https://crrev.com/b7358341b5ef6110ff7fedaf3cb5f978deb379ae/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
[modify] https://crrev.com/b7358341b5ef6110ff7fedaf3cb5f978deb379ae/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/b7358341b5ef6110ff7fedaf3cb5f978deb379ae/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/b7358341b5ef6110ff7fedaf3cb5f978deb379ae/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
[modify] https://crrev.com/b7358341b5ef6110ff7fedaf3cb5f978deb379ae/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f2e9b8061e21deebc96e0505d77e77bb9d14551

commit 9f2e9b8061e21deebc96e0505d77e77bb9d14551
Author: alph <alph@chromium.org>
Date: Wed Aug 24 23:38:52 2016

DevTools: make hitCount optional & experimental in Profiler domain.

Prepare to remove it as it can be computed out of samples.
Also rename CPUProfile to Profile.

BUG= 635947 

Review-Url: https://codereview.chromium.org/2279513002
Cr-Commit-Position: refs/heads/master@{#414199}

[modify] https://crrev.com/9f2e9b8061e21deebc96e0505d77e77bb9d14551/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-flame-chart-overview.html
[modify] https://crrev.com/9f2e9b8061e21deebc96e0505d77e77bb9d14551/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html
[modify] https://crrev.com/9f2e9b8061e21deebc96e0505d77e77bb9d14551/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js
[modify] https://crrev.com/9f2e9b8061e21deebc96e0505d77e77bb9d14551/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js
[modify] https://crrev.com/9f2e9b8061e21deebc96e0505d77e77bb9d14551/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfilerModel.js
[modify] https://crrev.com/9f2e9b8061e21deebc96e0505d77e77bb9d14551/third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js
[modify] https://crrev.com/9f2e9b8061e21deebc96e0505d77e77bb9d14551/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/9f2e9b8061e21deebc96e0505d77e77bb9d14551/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
[modify] https://crrev.com/9f2e9b8061e21deebc96e0505d77e77bb9d14551/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h
[modify] https://crrev.com/9f2e9b8061e21deebc96e0505d77e77bb9d14551/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/420512c42cfa7ff5260fc6ebc7ae656447cd3b67

commit 420512c42cfa7ff5260fc6ebc7ae656447cd3b67
Author: dgozman <dgozman@chromium.org>
Date: Thu Aug 25 01:10:28 2016

[DevTools] Protocol version 1.2.

Moving most of Schema, Runtime, Debugger, Profiler and Emulation out of experimental.

BUG= 635947 

Review-Url: https://codereview.chromium.org/2272503002
Cr-Commit-Position: refs/heads/master@{#414241}

[modify] https://crrev.com/420512c42cfa7ff5260fc6ebc7ae656447cd3b67/chrome/test/data/extensions/api_test/debugger/background.js
[modify] https://crrev.com/420512c42cfa7ff5260fc6ebc7ae656447cd3b67/chrome/test/data/extensions/api_test/debugger_extension/background.js
[modify] https://crrev.com/420512c42cfa7ff5260fc6ebc7ae656447cd3b67/content/browser/devtools/protocol/schema_handler.cc
[delete] https://crrev.com/bb26b236a8318d63170ae1f45ac6daec4f68d091/third_party/WebKit/Source/core/inspector/browser_protocol-1.1.json
[add] https://crrev.com/420512c42cfa7ff5260fc6ebc7ae656447cd3b67/third_party/WebKit/Source/core/inspector/browser_protocol-1.2.json
[modify] https://crrev.com/420512c42cfa7ff5260fc6ebc7ae656447cd3b67/third_party/WebKit/Source/core/inspector/browser_protocol.json
[delete] https://crrev.com/bb26b236a8318d63170ae1f45ac6daec4f68d091/third_party/WebKit/Source/platform/v8_inspector/js_protocol-1.1.json
[add] https://crrev.com/420512c42cfa7ff5260fc6ebc7ae656447cd3b67/third_party/WebKit/Source/platform/v8_inspector/js_protocol-1.2.json
[modify] https://crrev.com/420512c42cfa7ff5260fc6ebc7ae656447cd3b67/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Status: Fixed (was: Assigned)

Sign in to add a comment