Issue metadata
Sign in to add a comment
|
Regression: 'Share audio' option is missing in the new desktop capture picker UI in Chrome OS |
||||||||||||||||||||||
Issue descriptionChrome Version: 54.0.2822.0 / 8685.0.0 dev Any chrome device What steps will reproduce the problem? (1) Install the latest extension for http://test.webrtc.org/manual/peer2peer/ in Chrome M54 Dev (2) Turn on "Desktop Share with tab source" flag in chrome://flags (3) Go to https://test.webrtc.org/manual/peer2peer/, and click on 'Screen Capture' button What is the expected output? 1. 3 tabs should be seen - Your Entire screen, Application Window, Chrome Tab 2. 'Share Audio' checkbox should be seen in 'Your Entire Screen' and 'Chrome tab' sections What do you see instead? Share audio checkbox seen only in 'Chrome Tab' section Note: This issue is not seen in M53 (install latest screen capture extension and enable "Desktop Share with tab source" and "Disable Desktop Capture Picker Window Old UI." flags in chrome://flags)
,
Aug 10 2016
It is a GN build file issue. It does not define macro USE_CRAS correctly for folder src/chrome/.
,
Aug 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a11f96c9b693810431906e090a5c1ce6b2790dd commit 5a11f96c9b693810431906e090a5c1ce6b2790dd Author: qiangchen <qiangchen@chromium.org> Date: Thu Aug 11 00:25:14 2016 Bug Fix: Set USE_CRAS for //chrome and //chrome/ui After GYP to GN migration, we found "share audio" checkbox is not displayed on the desktop share picker window for ChromeOS. The reason is that macro USE_CRAS is not properly set. In this CL, we fix this issue. BUG= 635944 Review-Url: https://codereview.chromium.org/2234943002 Cr-Commit-Position: refs/heads/master@{#411200} [modify] https://crrev.com/5a11f96c9b693810431906e090a5c1ce6b2790dd/chrome/browser/BUILD.gn [modify] https://crrev.com/5a11f96c9b693810431906e090a5c1ce6b2790dd/chrome/browser/ui/BUILD.gn
,
Aug 11 2016
,
Aug 15 2016
Verified this issue on device Squawks with M54 54.0.2826.0 / 8708.0.0 dev. "Share audio" option is available in the new desktop capture UI. Observed that selected window (for screen sharing)is not visible in "Local Preview" of the extension. Closing this bug as verified and filed a new issue : https://bugs.chromium.org/p/chromium/issues/detail?id=637999
,
Aug 17 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jansson@chromium.org
, Aug 10 2016