New issue
Advanced search Search tips

Issue 635938 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 635912
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.2%-22.9% regression in blink_perf.parser at 410309:410329

Project Member Reported by rmcilroy@chromium.org, Aug 9 2016

Issue description

See the link to graphs below.
 

===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@410316  283.455  3.45456  5  good
chromium@410317  250.131  2.43001  5  bad
chromium@410318  252.762  1.68316  5  bad
chromium@410319  255.202  3.49358  5  bad
chromium@410322  254.833  3.15882  5  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 635938

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.parser
Test Metric: iframe-append-remove/iframe-append-remove
Relative Change: 10.10%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6630
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004794303904462432


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5290389431386112

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@410316  283.455  3.45456  5  good
chromium@410317  250.131  2.43001  5  bad
chromium@410318  252.762  1.68316  5  bad
chromium@410319  255.202  3.49358  5  bad
chromium@410322  254.833  3.15882  5  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 635938

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.parser
Test Metric: iframe-append-remove/iframe-append-remove
Relative Change: 10.10%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6630
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004794303904462432


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5290389431386112

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Mergedinto: 635912
Status: Duplicate (was: Assigned)
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Aug 11 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland of [api] Clean up scopes and precheck instantiations cache (patchset #1 id:1 of https://codereview.chromium.org/2216903003/ )
Author  : cbruni
Commit description:
  
Reason for revert:
asan failures are caused by a flaky stack-verflow (see https://codereview.chromium.org/2218033002 for a fix).

Original issue's description:
> Revert of [api] Clean up scopes and precheck instantiations cache (patchset #3 id:40001 of https://codereview.chromium.org/2206773003/ )
>
> Reason for revert:
> [Sheriff] Leads to mac asan failures:
> https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/7835
>
> Original issue's description:
> > [api] Clean up scopes and precheck instantiations cache
> >
> > Make sure all the scopes used in api-natives.cc have inlineable constructors
> > and destructors. Additionally directly precheck the instantiations cache before
> > trying to enter the InvokeScope which sets the save_context.
> >
> > BUG=chromium:630217
> >
> > Committed: https://crrev.com/a2496b942cad524f0f3144b107936eaa9a7c9fd5
> > Cr-Commit-Position: refs/heads/master@{#38346}
>
> TBR=yangguo@chromium.org,cbruni@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:630217
>
> Committed: https://crrev.com/e1b5cb43a9b90546ff5d6cea89ba17c485e842fb
> Cr-Commit-Position: refs/heads/master@{#38356}

TBR=yangguo@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:630217

Review-Url: https://codereview.chromium.org/2217353002
Cr-Commit-Position: refs/heads/master@{#38401}
Commit  : 56c8814c0bfca2f4993a4f23537aed1ac4363a6f
Date    : Fri Aug 05 20:24:16 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev   N  Good?
chromium@410316                35.5836  0.220743  5  good
chromium@410316,v8@6b2d24fe8f  35.6388  0.276124  5  good
chromium@410316,v8@4943f72272  36.603   0.603292  5  good
chromium@410316,v8@56c8814c0b  40.0726  0.750565  5  bad    <--
chromium@410317                40.373   0.7442    5  bad
chromium@410318                40.6614  0.655703  5  bad
chromium@410319                40.5778  0.537524  5  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 635938

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.layout
Test Metric: Shapes_MultipleShapes/Shapes_MultipleShapes
Relative Change: 14.04%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/493
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004794303904462432


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5290389431386112

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment