New issue
Advanced search Search tips

Issue 635937 link

Starred by 1 user
Status: Fixed
Owner:
peconn@chromium.org
Closed: Aug 2016
Cc:
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add a 'do not fail on render test' flag to test_runner.py

Project Member Reported by peconn@chromium.org, Aug 9 2016 
For the RenderTests (https://codereview.chromium.org/2114963002) it would be convenient to have a flag that prevents RenderUtils from throwing when a View does not match the golden but still renders the View to a file.

Therefore when someone has made a UI change they can generate all the new golden files in one test run.

Suggested flag names:
- generate-goldens
- generate-renders
- render-test-do-not-fail

Comment 1 by jbudorick@chromium.org, Aug 9 2016 

I'd probably say --regenerate-goldens.

Anyhow, for implementing this, we'd need to:

 - add it to test_runner.py (https://codesearch.chromium.org/chromium/src/build/android/test_runner.py?rcl=0&l=366). Beware that our options are kind of a disaster at the moment.
 - add the java-side flag to InstrumentationTestInstance._initializeFlagAttributes: https://codesearch.chromium.org/chromium/src/build/android/pylib/instrumentation/instrumentation_test_instance.py?rcl=0&l=504

These two should be sufficient to get whatever the java-side flag is into the CommandLine instance. We'll then probably want to implement a custom assertion that doesn't fail if the java-side flag is set.

Comment 2 by jbudorick@chromium.org, Aug 9 2016

Components: Test>Android
Labels: OS-Android

Comment 4 by jbudorick@chromium.org, Aug 27 2016

Cc: -peconn@chromium.org jbudorick@chromium.org
Owner: peconn@chromium.org
peconn: AFAIK the CL in #3 did this, but I'll leave it to you to close this out.

Comment 5 by peconn@chromium.org, Aug 27 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment