New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635935 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Create Earl Grey macros to conditionally disable a test

Project Member Reported by baxley@chromium.org, Aug 9 2016

Issue description

Create macros to disable tests for a bug, and skip tests when the test doesn't apply. (e.g. on an unsupported platform)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/70692f5205f745f392d13a42a79e81f99db1a37c

commit 70692f5205f745f392d13a42a79e81f99db1a37c
Author: baxley <baxley@google.com>
Date: Tue Aug 09 16:42:40 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d674e7bc7369c5fd08b8caffa1a9765c14b6cf75

commit d674e7bc7369c5fd08b8caffa1a9765c14b6cf75
Author: baxley <baxley@chromium.org>
Date: Tue Aug 09 22:56:53 2016

Add macro for consistent logging when disabling tests.

There are two macros, one for disabled tests and ones where a test
is skipped (e.g. unsupported platform, rather than a bug).

BUG= 635935 

Review-Url: https://codereview.chromium.org/2224313003
Cr-Commit-Position: refs/heads/master@{#410860}

[modify] https://crrev.com/d674e7bc7369c5fd08b8caffa1a9765c14b6cf75/ios/testing/earl_grey/BUILD.gn
[add] https://crrev.com/d674e7bc7369c5fd08b8caffa1a9765c14b6cf75/ios/testing/earl_grey/disabled_test_macros.h
[modify] https://crrev.com/d674e7bc7369c5fd08b8caffa1a9765c14b6cf75/ios/testing/earl_grey/earl_grey_support.gyp

Comment 3 by baxley@chromium.org, Aug 10 2016

Status: Fixed (was: Started)

Sign in to add a comment