New issue
Advanced search Search tips

Issue 635933 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 609258



Sign in to add a comment

Do not show "Add to Homescreen Dialog" when user taps "Add to Homescreen" on WebAPK-able site

Project Member Reported by pkotw...@chromium.org, Aug 9 2016

Issue description

Do not show "Add to Homescreen Dialog" when user taps "Add to Homescreen" on WebAPK-able site

 
Owner: pkotw...@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/787d2c9027fbc34ae35eee586a24d59124266718

commit 787d2c9027fbc34ae35eee586a24d59124266718
Author: hanxi <hanxi@chromium.org>
Date: Tue Sep 06 17:41:21 2016

Commit this CL on behalf of pkotwicz@. The original CL is:
https://codereview.chromium.org/2244223002/

Determine whether to show "Add to Homescreen" dialog or WebAPK infobar

This CL:
- Introduces a new class, AddToHomescreenProcess, which manages the
add-to-homescreen process. AddToHomescreenProcess is largely copied from
AddToHomescreenDialogHelper
- The CL adds logic to AddToHomescreenProcess to determine whether to show
the add-WebAPK-to-homescreen infobar instead of the add-to-homescreen dialog.
- Changes the entry point for adding a page to the homescreen from
AddToHomescreenDialog#show() to AddToHomescreenProcess#start()

BUG=627250,606430, 635933 

Review-Url: https://codereview.chromium.org/2292133003
Cr-Commit-Position: refs/heads/master@{#416649}

[modify] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java
[delete] https://crrev.com/2b37f970d038cb432054b534bd7d832c71151ee3/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
[add] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenManager.java
[modify] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/android/java_sources.gni
[modify] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogTest.java
[add] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java
[modify] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/browser/BUILD.gn
[modify] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
[add] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[add] https://crrev.com/787d2c9027fbc34ae35eee586a24d59124266718/chrome/browser/android/webapps/add_to_homescreen_manager.h

Comment 4 by hanxi@chromium.org, Sep 9 2016

Status: Fixed (was: Started)

Sign in to add a comment