New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635913 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

GN error with target_cpu="arm64", use_errorprone_java_compiler=true

Project Member Reported by mge...@chromium.org, Aug 9 2016

Issue description

When using both of these build args, I get this error:

ERROR Input to target not generated by a dependency.
The file:
  //out/Release/lib.java/third_party/errorprone/javac_java.jar
is listed as an input or source for the target:
  //third_party/errorprone:chromium_errorprone__java_binary_script(//build/toolchain/android:arm)
but this file was not generated by any dependencies of the target. The target
that generates the file is:
  //third_party/errorprone:javac_java__process_jar__copy(//build/toolchain/android:arm64)

 
'use_errorprone_java_compiler' flag is not set on the bots. That is why we don't see the problem there. These are the bot args: 

disable_brotli_filter=true disable_file_support=true disable_ftp_support=true enable_websockets=false use_platform_icu_alternatives=true is_component_build=false symbol_level=1 is_debug=true target_os="android" target_cpu="arm64" use_goma=true goma_dir="/b/build/slave/cache/cipd/goma"
 
Cc: jbudorick@chromium.org
Labels: -Pri-3 Pri-2
jbudorick@: do you know where component should this bug be assigned to?
Owner: mikec...@chromium.org
Status: Assigned (was: Untriaged)
What target were you building and what were your GN args? I was just able to build chrome_apk with the following args without issue.

use_goma = true
target_os = "android"
is_debug = true
target_cpu = "arm64"
use_errorprone_java_compiler = true
use_errorprone_java_compiler = true
arm_use_neon = false
target_os = "android"
enable_websockets = false
disable_file_support = true
disable_ftp_support = true
use_platform_icu_alternatives = true
disable_brotli_filter = true
is_component_build = false
use_goma=true
target_cpu="arm64"

Calling "gn args out/Debug/" fails with the originally mentioned error.
Status: Started (was: Assigned)
Thanks for the info :D For me it is the setting of "use_platform_icu_alternatives = true" that causes this issue. Im not sure at all why this triggers this particular error (it kinda seems like this error should always occur).

But, I understand what is wrong and working on fix. 
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71fc2fa22d4d1da0cfdcd430f011b4bbf9afebff

commit 71fc2fa22d4d1da0cfdcd430f011b4bbf9afebff
Author: mikecase <mikecase@chromium.org>
Date: Wed Oct 05 21:07:35 2016

Remove bootclasspath variable from list of testrunner script inputs.

There is only 1 instance in which the bootclasspath variable is
currently used. In this case, adding bootclasspath as an input
sometimes causes an error where GN complains that there is no
path (via public_deps) to the target that generates the input file.

Since public_deps is not supported for java_prebuilt targets, I
think the simplest thing to do is just remove this file from
list of inputs.

BUG= 635913 

Review-Url: https://codereview.chromium.org/2388153006
Cr-Commit-Position: refs/heads/master@{#423289}

[modify] https://crrev.com/71fc2fa22d4d1da0cfdcd430f011b4bbf9afebff/build/config/android/internal_rules.gni

Status: Fixed (was: Started)
This should be fixed now.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71fc2fa22d4d1da0cfdcd430f011b4bbf9afebff

commit 71fc2fa22d4d1da0cfdcd430f011b4bbf9afebff
Author: mikecase <mikecase@chromium.org>
Date: Wed Oct 05 21:07:35 2016

Remove bootclasspath variable from list of testrunner script inputs.

There is only 1 instance in which the bootclasspath variable is
currently used. In this case, adding bootclasspath as an input
sometimes causes an error where GN complains that there is no
path (via public_deps) to the target that generates the input file.

Since public_deps is not supported for java_prebuilt targets, I
think the simplest thing to do is just remove this file from
list of inputs.

BUG= 635913 

Review-Url: https://codereview.chromium.org/2388153006
Cr-Commit-Position: refs/heads/master@{#423289}

[modify] https://crrev.com/71fc2fa22d4d1da0cfdcd430f011b4bbf9afebff/build/config/android/internal_rules.gni

Comment 10 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment