New issue
Advanced search Search tips

Issue 635912 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue 636310



Sign in to add a comment

12.7%-61.6% regression in blink_perf.bindings at 410302:410322

Project Member Reported by rmcilroy@chromium.org, Aug 9 2016

Issue description

See the link to graphs below.
 

===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@410316  202.633  9.19015  8  good
chromium@410317  180.718  2.73997  5  bad
chromium@410318  179.405  8.73252  8  bad
chromium@410319  177.812  1.97502  8  bad

Bisect job ran on: winx64nvidia_perf_bisect
Bug ID: 635912

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.bindings
Test Metric: node-list-access/node-list-access
Relative Change: 11.35%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1798
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004797006709072256


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5896883373867008

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@410316  202.633  9.19015  8  good
chromium@410317  180.718  2.73997  5  bad
chromium@410318  179.405  8.73252  8  bad
chromium@410319  177.812  1.97502  8  bad

Bisect job ran on: winx64nvidia_perf_bisect
Bug ID: 635912

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.bindings
Test Metric: node-list-access/node-list-access
Relative Change: 11.35%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1798
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004797006709072256


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5896883373867008

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Blockedon: 636310
Cc: rmcilroy@chromium.org
Owner: cbruni@chromium.org
The bisects are pointing to the V8 roll to 5.4.365, but not descending into the roll for some reason - filled https://github.com/catapult-project/catapult/issues/2643 for this issue.

As for the regression - Camillo, your CL "Reland of [api] Clean up scopes and precheck instantiations cache" seems the most related to the benchmark, could you have a look (please assign back to me if it isn't relevant)?

Comment 8 by cbruni@chromium.org, Aug 10 2016

I will try to partially revert my CL as I've seen some minor regressions on our RuntimeStats benchmarks as well.
 Issue 635938  has been merged into this issue.
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Aug 11 2016

Cc: cbruni@chromium.org

=== Auto-CCing suspected CL author cbruni@chromium.org ===

Hi cbruni@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland of [api] Clean up scopes and precheck instantiations cache (patchset #1 id:1 of https://codereview.chromium.org/2216903003/ )
Author  : cbruni
Commit description:
  
Reason for revert:
asan failures are caused by a flaky stack-verflow (see https://codereview.chromium.org/2218033002 for a fix).

Original issue's description:
> Revert of [api] Clean up scopes and precheck instantiations cache (patchset #3 id:40001 of https://codereview.chromium.org/2206773003/ )
>
> Reason for revert:
> [Sheriff] Leads to mac asan failures:
> https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/7835
>
> Original issue's description:
> > [api] Clean up scopes and precheck instantiations cache
> >
> > Make sure all the scopes used in api-natives.cc have inlineable constructors
> > and destructors. Additionally directly precheck the instantiations cache before
> > trying to enter the InvokeScope which sets the save_context.
> >
> > BUG=chromium:630217
> >
> > Committed: https://crrev.com/a2496b942cad524f0f3144b107936eaa9a7c9fd5
> > Cr-Commit-Position: refs/heads/master@{#38346}
>
> TBR=yangguo@chromium.org,cbruni@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:630217
>
> Committed: https://crrev.com/e1b5cb43a9b90546ff5d6cea89ba17c485e842fb
> Cr-Commit-Position: refs/heads/master@{#38356}

TBR=yangguo@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:630217

Review-Url: https://codereview.chromium.org/2217353002
Cr-Commit-Position: refs/heads/master@{#38401}
Commit  : 56c8814c0bfca2f4993a4f23537aed1ac4363a6f
Date    : Fri Aug 05 20:24:16 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N  Good?
chromium@410316                198.33   3.74561  8  good
chromium@410316,v8@6b2d24fe8f  202.712  2.8893   5  good
chromium@410316,v8@4943f72272  200.862  2.193    5  good
chromium@410316,v8@56c8814c0b  171.404  2.26668  5  bad    <--
chromium@410317                172.924  9.40419  5  bad
chromium@410318                173.8    9.75682  8  bad
chromium@410319                170.45   3.74875  5  bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 635912

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.bindings
Test Metric: node-list-access/node-list-access
Relative Change: 14.86%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1101
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004797006709072256


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5896883373867008

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
I am not convinced by this regression blink_perf.bindings.node-list-access.

It seems to only show up on the win-gpu bots (all other windows bots are unaffected), at the same time I see the error rate going up on the chrome graphs.

The main cause for the regression (and the high variance) is gc timing since I slightly increase the heap size from start (which is currently still a bug).
The highlighted CL regresses Group-API total by 10%. We should probably revert and figure out the issue before we reland?
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/85575cd8ee33fa3dd49ffc58de6e0b958df29094

commit 85575cd8ee33fa3dd49ffc58de6e0b958df29094
Author: cbruni <cbruni@chromium.org>
Date: Fri Sep 23 16:01:20 2016

Revert of [api] Clean up scopes and precheck instantiations cache (patchset #3 id:40001 of https://codereview.chromium.org/2206773003/ )

Reason for revert:
Regresses API see go/v8-startup-api

Original issue's description:
> [api] Clean up scopes and precheck instantiations cache
>
> Make sure all the scopes used in api-natives.cc have inlineable constructors
> and destructors. Additionally directly precheck the instantiations cache before
> trying to enter the InvokeScope which sets the save_context.
>
> BUG=chromium:630217
>
> Committed: https://crrev.com/a2496b942cad524f0f3144b107936eaa9a7c9fd5
> Cr-Commit-Position: refs/heads/master@{#38346}

TBR=yangguo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:630217,  chromium:635912 

Review-Url: https://codereview.chromium.org/2366903003
Cr-Commit-Position: refs/heads/master@{#39680}

[modify] https://crrev.com/85575cd8ee33fa3dd49ffc58de6e0b958df29094/src/api-natives.cc
[modify] https://crrev.com/85575cd8ee33fa3dd49ffc58de6e0b958df29094/src/isolate-inl.h
[modify] https://crrev.com/85575cd8ee33fa3dd49ffc58de6e0b958df29094/src/isolate.cc
[modify] https://crrev.com/85575cd8ee33fa3dd49ffc58de6e0b958df29094/src/isolate.h

Status: Fixed (was: Assigned)
Our own (more stable) graphs have recovered after the above revert.
The graphs for this issue recovered already by themselves.

Sign in to add a comment