New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635909 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html too slow

Project Member Reported by foolip@chromium.org, Aug 9 2016

Issue description

It's in SlowTests, but still times out in debug occasionally:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Fsources%2Fdebugger-frameworks%2Fframeworks-dom-xhr-event-breakpoints.html

When the test does pass, it can take >80 seconds.

Maybe this should be split into multiple tests, or it should be written as another type of test to make it faster?
 
See also  issue 498539 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddfc73f1607f8342b1801797648662071df7898b

commit ddfc73f1607f8342b1801797648662071df7898b
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Tue Aug 09 14:46:07 2016

Allow a very slow inspector test to timeout in debug

BUG= 635909 
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/2228653003 .

Cr-Commit-Position: refs/heads/master@{#410670}

[modify] https://crrev.com/ddfc73f1607f8342b1801797648662071df7898b/third_party/WebKit/LayoutTests/TestExpectations

This test has also been timing out pretty often on the Site Isolation Win bot, which is a release bot.  For example:
https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/15755
https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/15753

I'm going to allow this to time out in release mode as well to get that bot green.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92a2b902b2c4af08c69a4f252d6d94f842e3e98d

commit 92a2b902b2c4af08c69a4f252d6d94f842e3e98d
Author: alexmos <alexmos@chromium.org>
Date: Thu Aug 18 18:05:53 2016

Allow a very slow test to time out.

In addition to debug builds, frameworks-dom-xhr-event-breakpoints.html
has been timing out on Site Isolation Win, which is a Win7 release
bot, so allow it to time out on that platform as well.

BUG= 635909 
TBR=pfeldman@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2260593002
Cr-Commit-Position: refs/heads/master@{#412890}

[modify] https://crrev.com/92a2b902b2c4af08c69a4f252d6d94f842e3e98d/third_party/WebKit/LayoutTests/TestExpectations

Owner: kozyatinskiy@chromium.org
There are still NeedsManualRebaseline lines in TestExpectations associated with this bug. Besides rebaselining (with webkit-patch rebaseline or some other mechanism), what else is left to do for this bug?
Status: Fixed (was: Assigned)

Sign in to add a comment