Need an option to skip debugger keyword
Reported by
gmarke...@gmail.com,
Aug 9 2016
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Steps to reproduce the problem: 1. Bad author makes new function via eval and timeout with debugger keyword in it 2. You open devtools to find something, for example Network activity 3. Browser switches to Sources tab and pause script execution on generated function and debugger keyword in it What is the expected behavior? No pause, no switch. What went wrong? Bad browser behavior if devtools is opened. Did this work before? N/A Chrome version: 52.0.2743.116 Channel: stable OS Version: Flash Version: Shockwave Flash 22.0 r0 We need an options to ignore such behavior. Maybe checkbox in devtools settings: [x] do not pause on debugger keyword
,
Aug 10 2016
As the issue of type-feature marking it as Untriaged to get it addressed. Thanks,
,
Aug 10 2016
You can temporary disable all breakpoints in sources panel. It will disable debugger statement too. If evaluated script has sourceURL then you can use never pause here item in context menu. If script is anonymous we can implement provisional breakpoints for them by source hash.
,
Aug 13 2016
Add a breakpoint with condition "false" on that line.
,
Aug 14 2016
Not fixed. If bad author generates multiple functions in a loop. Real life example: https://www.avito.ru
,
Aug 22 2016
,
Aug 22 2016
This author makes something more then just loop. They run recursive function with debugger statement and wait until stack overflow exception happens. If "deactivate breakpoints" is checked then you will be able to debug this page and will skip all debugger statements. Never pause here won't help because it's not designed to skip a huge amount of breakpoints or breakpoint with condition "false".
,
Sep 14 2017
ubuntu 1604 chrome 61.0.3163.79 chrome 0x2812396-0x28123d7 e.........b.........u.........g.........g.........e..............r 62 0F 85 AA 03 00 00 80 7F 03 75 0F 85 A0 03 00 00 80 7F 04 67 0F 85 96 03 00 00 80 7F 05 67 0F 85 8C 03 00 00 80 7F 06 65 0F 85 82 03 00 00 B8 3F 00 00 00 80 7F 07 72
,
Sep 14 2017
v8/src/parsing/scanner.cc
--KEYWORD("debugger", Token::DEBUGGER)
++KEYWORD("debugger", Token::SEMICOLON)
diff d8_old d8_new
ubuntu 1604
chrome 61.0.3163.79
0x28123d0 3f->08
debugger disabled
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ligim...@chromium.org
, Aug 9 2016