New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635905 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 436283



Sign in to add a comment

bluetooth: Duplicate chooser when clicking twice on Mac.

Project Member Reported by ortuno@chromium.org, Aug 9 2016

Issue description


1. Go to https://googlechrome.github.io/samples/web-bluetooth/device-info.html
2. Press button twice

Expected:
Chooser opens the immediately closes when the second click happens and opens again.

What happens?
Two choosers are opened.

This patch[1] fixed the crash but we still show two choosers.

[1] http://crrev.com/2203103003
 

Comment 1 by ortuno@chromium.org, Aug 19 2016

Description: Show this description

Comment 2 Deleted

Comment 3 Deleted

Comment 4 Deleted

Owner: juncai@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a

commit 6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a
Author: ortuno <ortuno@chromium.org>
Date: Tue Sep 13 21:47:14 2016

bluetooth: setShouldCloseOnResignKey so that the chooser closes when it loses focus

Before users could click a button multiple times and it would open multiple choosers. With
this change the chooser will loose focus as soon as the user clicks outside the chooser.

BUG= 635905 

Review-Url: https://codereview.chromium.org/2333183002
Cr-Commit-Position: refs/heads/master@{#418380}

[modify] https://crrev.com/6e0ec0d0f1f709a1e2de02d439bcedbf6c3cb66a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

Comment 7 by ortuno@chromium.org, Sep 13 2016

Status: Fixed (was: Available)

Comment 8 by ortuno@chromium.org, Mar 22 2018

Owner: ortuno@chromium.org

Sign in to add a comment