chrome side bug for b/30740010
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbd18684621964b72a64cc91775c89721cc07a4f commit cbd18684621964b72a64cc91775c89721cc07a4f Author: oshima <oshima@chromium.org> Date: Wed Aug 17 17:03:40 2016 Do not automatically maximize the window if the maximized bounds can be controlled by the client in Tablet mode (aka Maximized mode), which all arc windows are. The maximizing in tablet mode will be handled on arndroid side. BUG= 635899 TEST=MaximizeModeWindowManagerTest.DontMaximizeClientManagedWindows Review-Url: https://codereview.chromium.org/2249953002 Cr-Commit-Position: refs/heads/master@{#412566} [modify] https://crrev.com/cbd18684621964b72a64cc91775c89721cc07a4f/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/cbd18684621964b72a64cc91775c89721cc07a4f/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
oshima@ let me know if you need to merge this into M53 post merge to Master.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ef3cfef16fad285e84d8655e592d522401b6ff8 commit 5ef3cfef16fad285e84d8655e592d522401b6ff8 Author: oshima <oshima@chromium.org> Date: Thu Aug 18 17:42:45 2016 Register the window in MaximizeModeWindowManager when the window is shown. This is necessary for arc app to set the "don't manage me" flag. BUG= 635899 Review-Url: https://codereview.chromium.org/2250963006 Cr-Commit-Position: refs/heads/master@{#412882} [modify] https://crrev.com/5ef3cfef16fad285e84d8655e592d522401b6ff8/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/5ef3cfef16fad285e84d8655e592d522401b6ff8/ash/common/wm/maximize_mode/maximize_mode_window_manager.h
Approving merge to M53 cros.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/739c479e48067b5df7fe7698563289d429a0759a commit 739c479e48067b5df7fe7698563289d429a0759a Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Aug 19 00:32:51 2016 Do not automatically maximize the window if the maximized bounds can be controlled by the client in Tablet mode (aka Maximized mode), which all arc windows are. The maximizing in tablet mode will be handled on arndroid side. BUG= 635899 TEST=MaximizeModeWindowManagerTest.DontMaximizeClientManagedWindows Review-Url: https://codereview.chromium.org/2249953002 Cr-Commit-Position: refs/heads/master@{#412566} (cherry picked from commit cbd18684621964b72a64cc91775c89721cc07a4f) Review URL: https://codereview.chromium.org/2264443002 . Cr-Commit-Position: refs/branch-heads/2785@{#676} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/739c479e48067b5df7fe7698563289d429a0759a/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/739c479e48067b5df7fe7698563289d429a0759a/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c37e2d02b59b912e8a4bf83c4a0f0259282d4db commit 9c37e2d02b59b912e8a4bf83c4a0f0259282d4db Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Aug 19 00:51:45 2016 Register the window in MaximizeModeWindowManager when the window is shown. This is necessary for arc app to set the "don't manage me" flag. BUG= 635899 Review-Url: https://codereview.chromium.org/2250963006 Cr-Commit-Position: refs/heads/master@{#412882} (cherry picked from commit 5ef3cfef16fad285e84d8655e592d522401b6ff8) Do not automatically maximize the window if the maximized bounds can be controlled by the client in Tablet mode (aka Maximized mode), which all arc windows are. The maximizing in tablet mode will be handled on arndroid side. BUG= 635899 TEST=MaximizeModeWindowManagerTest.DontMaximizeClientManagedWindows Review-Url: https://codereview.chromium.org/2249953002 Cr-Commit-Position: refs/heads/master@{#412566} (cherry picked from commit cbd18684621964b72a64cc91775c89721cc07a4f) Review URL: https://codereview.chromium.org/2260083002 . Cr-Commit-Position: refs/branch-heads/2785@{#677} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/9c37e2d02b59b912e8a4bf83c4a0f0259282d4db/ash/common/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/9c37e2d02b59b912e8a4bf83c4a0f0259282d4db/ash/common/wm/maximize_mode/maximize_mode_window_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09b361d92cba6a2e1b78998f74ccda1f0485de39 commit 09b361d92cba6a2e1b78998f74ccda1f0485de39 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Aug 19 17:37:47 2016 Use MD-ash's auto hide behavior for arc++ windows. This add a runtime flag to enable MD-ash's auto hide behavior , which makes the shelf invisible, for arc++ windows. I'll remove this mode once MD ash is launched. BUG= 634566 TEST=covered by unit test. Manually tested on minnie. Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700 Review-Url: https://codereview.chromium.org/2248773002 Cr-Original-Commit-Position: refs/heads/master@{#412309} Cr-Commit-Position: refs/heads/master@{#412352} (cherry picked from commit 41fe96e27f8964dc1c6d9b4e7ffe3ad741b357ef) Register the window in MaximizeModeWindowManager when the window is shown. This is necessary for arc app to set the "don't manage me" flag. BUG= 635899 Review-Url: https://codereview.chromium.org/2250963006 Cr-Commit-Position: refs/heads/master@{#412882} (cherry picked from commit 5ef3cfef16fad285e84d8655e592d522401b6ff8) Review URL: https://codereview.chromium.org/2255313005 . Cr-Commit-Position: refs/branch-heads/2785@{#680} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/ash/common/wm/window_state.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/ash/common/wm/window_state.h [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/ash/system/web_notification/web_notification_tray_unittest.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/ash/wm/gestures/shelf_gesture_handler.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/ash/wm/immersive_fullscreen_controller.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/chrome/browser/notifications/fullscreen_notification_blocker.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/chrome/browser/ui/ash/accelerator_commands_browsertest.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc [modify] https://crrev.com/09b361d92cba6a2e1b78998f74ccda1f0485de39/components/exo/shell_surface.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6002f379e9052cda4a3573391d79179c95d3c97e commit 6002f379e9052cda4a3573391d79179c95d3c97e Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Aug 19 17:47:49 2016 Use MD-ash's auto hide behavior for arc++ windows. This add a runtime flag to enable MD-ash's auto hide behavior , which makes the shelf invisible, for arc++ windows. I'll remove this mode once MD ash is launched. BUG= 634566 TEST=covered by unit test. Manually tested on minnie. Committed: https://crrev.com/9913eed0106818160f3828ae7c2fd90dbf985700 Review-Url: https://codereview.chromium.org/2248773002 Cr-Original-Commit-Position: refs/heads/master@{#412309} Cr-Commit-Position: refs/heads/master@{#412352} (cherry picked from commit 41fe96e27f8964dc1c6d9b4e7ffe3ad741b357ef) Register the window in MaximizeModeWindowManager when the window is shown. This is necessary for arc app to set the "don't manage me" flag. BUG= 635899 Review-Url: https://codereview.chromium.org/2250963006 Cr-Commit-Position: refs/heads/master@{#412882} (cherry picked from commit 5ef3cfef16fad285e84d8655e592d522401b6ff8) Review URL: https://codereview.chromium.org/2255313005 . Committed: https://chromium.googlesource.com/chromium/src/+/09b361d92cba6a2e1b78998f74ccda1f0485de39 Cr-Commit-Position: refs/branch-heads/2785@{#681} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/6002f379e9052cda4a3573391d79179c95d3c97e/components/exo/shell_surface.cc [modify] https://crrev.com/6002f379e9052cda4a3573391d79179c95d3c97e/components/exo/shell_surface_unittest.cc
ChromeOS build 8530.96.0 / 53.0.2785.154
Comment 1 by bugdroid1@chromium.org
, Aug 17 2016