New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635892 link

Starred by 1 user
Status: Duplicate
Merged: issue 633707
Owner:
█ wkorman@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
chrishtr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Layout Test fast/repaint/resize-iframe-text.html is flaky

Project Member Reported by foolip@chromium.org, Aug 9 2016 
The following layout test is flaky on Mac 10.10, Win7 and Win7 dbg.

fast/repaint/resize-iframe-text.html

In all cases, it's an image failure because the scrollbars look different. The test was added recently in https://chromium.googlesource.com/chromium/src/+/74d1e73747b73764b50dfaf413344397c14b971f and has likely been flaky (or consistently failing on waterfall but not CQ?) since the beginning.

I will revert the CL which added the test.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee0c98a9d507510dbb7023b38fab8f786e882e11

commit ee0c98a9d507510dbb7023b38fab8f786e882e11
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Tue Aug 09 13:46:06 2016

Revert of Include non-composited layout views in existing workaround for clipping changes. (patchset #3 id:40001 of https://codereview.chromium.org/2212403004/ )

Reason for revert:
fast/repaint/resize-iframe-text.html is failing on Mac and Win.

The CL was landed with [ NeedsRebaseline ], so also remove the platform
expectations added with https://codereview.chromium.org/2221693002

BUG= 635892 

Original issue's description:
> Include non-composited layout views in existing workaround for clipping changes.
>
> BUG= 633869 
>
> Committed: https://crrev.com/74d1e73747b73764b50dfaf413344397c14b971f
> Cr-Commit-Position: refs/heads/master@{#410222}

TBR=chrishtr@chromium.org,wkorman@chromium.org
BUG= 633869 

Review URL: https://codereview.chromium.org/2220423004 .

Cr-Commit-Position: refs/heads/master@{#410652}

[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/fast/repaint/resize-iframe-text.html
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/fast/repaint/resources/resize-iframe-text-src.html
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-iframe-text-expected.txt
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/resize-iframe-text-expected.txt
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/resize-iframe-text-expected.txt
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/resize-iframe-text-expected.txt
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/win/fast/repaint/resize-iframe-text-expected.png
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/win/fast/repaint/resize-iframe-text-expected.txt
[delete] https://crrev.com/c41d2181a2c4d3c2c735d22794e00ac292959c73/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/resize-iframe-text-expected.png
[modify] https://crrev.com/ee0c98a9d507510dbb7023b38fab8f786e882e11/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Comment 2 by foolip@chromium.org, Aug 9 2016 

Hmm. It could be that the code or test change themselves aren't at fault, as there are now other tests, that aren't new, that are also failing with similar scrollbar differences, in fast/forms/select-popup/

Comment 3 by schenney@chromium.org, Aug 9 2016

Mergedinto: 633707
Status: Duplicate (was: Assigned)
This is a known issue with scrollbars.

Comment 4 by wkorman@chromium.org, Aug 9 2016 

My interpretation of above is that it is reasonable for me to re-land the revert https://codereview.chromium.org/2220423004. Doing so now, or let me know if otherwise.
►

Sign in to add a comment