Issue metadata
Sign in to add a comment
|
14% regression in browser_tests at 410478:410485 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 9 2016
The Chrome FYI bots found a regression. isheriff: I wonder if you know whether the CL https://codereview.chromium.org/2217623002 could have caused this?
,
Aug 9 2016
Did you mean to paste a different CL url ?
,
Aug 15 2016
Yes, it looks as if I pasted in the wrong URL. Sorry! Will take another look.
,
Aug 15 2016
ehmaldonado@: Could the reason for this be the same as for https://bugs.chromium.org/p/chromium/issues/detail?id=637568
,
Aug 15 2016
peah@: No, I don't think so.
,
Aug 15 2016
,
Aug 22 2016
brandtr@ I cannot make any sense of which CL could have caused this regression. Do you have any suggestion of what could have caused it?
,
Aug 22 2016
When looking at the buildbot stdio, the only CL in the blamelist is this one: https://codereview.webrtc.org/2228683002. I'm not intimately familiar with this test, but this CL could plausibly be the reason for the change. tkchin@: Would you mind having a look at this performance regression, to see if it is expected? peah@: Do you think the 'agc_energy_diff_with_agc/speech_44kHz_16bit_stereo.wav_segment_1' change in the graphs is related to the 'Unique_frames_count/720p_H264' change?
,
Aug 22 2016
No, that looks unrelated, and was probably incorrectly included in this issue by me. I'm looking at that in another regression issue.
,
Aug 22 2016
,
Aug 22 2016
I don't know enough about the test to comment. But https://codereview.webrtc.org/2228683002 has been updated by https://codereview.webrtc.org/2248883002/ which, if indeed was the cause for the regression, should go back to normal since the change is now iOS specific.
,
Aug 23 2016
Yep, the follow-up CL has made the metrics go back up on Windows and Linux. The corresponding alert was apparently ignored in the dashboard though. Thanks for the info, tkchin@! peah@: Not sure if you are tracking the "agc_energy_diff_with_agc" alert in another bug or not. If so, you could close this one.
,
Aug 23 2016
Removing the agc_energy_diff_with_agc alert off this bug, and closing since the update in #12 fixed the regression.
,
Aug 23 2016
Thanks! I'm tracking the agc issue in another bug. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by peah@chromium.org
, Aug 9 2016