New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635880 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

checklicense step failing for Linux Tests builder after SwiftShader DEPS change

Project Member Reported by foolip@chromium.org, Aug 9 2016

Issue description

https://build.chromium.org/p/chromium.linux/waterfall?builder=Linux%20Tests

https://chromium.googlesource.com/chromium/src/+/86cd5c0e5b8f427d600fce40b88749d8664e9ef6 dropped SwiftShader from DEPS, and since then the checklicense step has been failing. It's probably left on disk on the builder, and phajdan guesses it's because it's still in .gitignore.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/341fac67de9500a95d8ed16545a9b0e1f859991d

commit 341fac67de9500a95d8ed16545a9b0e1f859991d
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Tue Aug 09 13:12:49 2016

Drop third_party/swiftshader/ from .gitignore

It's no longer in DEPS, and its precense in .gitignore may be why it's
still left in the checkout causing checklicenses failures.

BUG= 635880 
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/2224093003 .

Cr-Commit-Position: refs/heads/master@{#410647}

[modify] https://crrev.com/341fac67de9500a95d8ed16545a9b0e1f859991d/.gitignore

Status: Fixed (was: Started)

Comment 3 by capn@chromium.org, Aug 15 2016

Cc: capn@chromium.org sugoi@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/924e6f4db66fdeac8f95c9cb04e671281604b9ea

commit 924e6f4db66fdeac8f95c9cb04e671281604b9ea
Author: pkasting <pkasting@chromium.org>
Date: Tue Aug 16 03:53:01 2016

Revert of Drop third_party/swiftshader/ from .gitignore (patchset #1 id:1 of https://codereview.chromium.org/2224093003/ )

Reason for revert:
This was re-added to DEPS and is now showing up as untracked again.

Original issue's description:
> Drop third_party/swiftshader/ from .gitignore
>
> It's no longer in DEPS, and its precense in .gitignore may be why it's
> still left in the checkout causing checklicenses failures.
>
> BUG= 635880 
> TBR=stevenjb@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/341fac67de9500a95d8ed16545a9b0e1f859991d

TBR=stevenjb@chromium.org,capn@chromium.org,sugoi@chromium.org,foolip@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 635880 

Review-Url: https://codereview.chromium.org/2250003002
Cr-Commit-Position: refs/heads/master@{#412160}

[modify] https://crrev.com/924e6f4db66fdeac8f95c9cb04e671281604b9ea/.gitignore

Comment 5 by capn@chromium.org, Aug 16 2016

 Issue 637951  has been merged into this issue.

Comment 6 Deleted

Sign in to add a comment