New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635874 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 614277



Sign in to add a comment

MD Site Settings: Support deep linking to sites

Project Member Reported by finnur@chromium.org, Aug 9 2016

Issue description

Tommy recently added support for parameters in routes. That means we can now deep link into site details to get it to populate data for a given site (or simply refresh the Site Details page and not lose all the state). 
 

Comment 1 by finnur@chromium.org, Aug 23 2016

Cc: finnur@chromium.org tommycli@chromium.org
 Issue 639946  has been merged into this issue.

Comment 2 by finnur@chromium.org, Aug 23 2016

Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
Matching assignee of duped bug.
Components: UI>Settings
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acf8c15189e568e8185b8c278cfa49e751dc1061

commit acf8c15189e568e8185b8c278cfa49e751dc1061
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Sep 16 01:26:07 2016

[MD settings] add getSiteDetails to site settings browser proxy

This CL is a step toward deep linking to site details in the site
settings. This CL adds the c++ handler backend and does show the
exceptions in the UI. The page title is not updated with the subject URL,
but that is not a regression and will be addressed in a future CL.

BUG= 635874 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338163004
Cr-Commit-Position: refs/heads/master@{#419071}

[modify] https://crrev.com/acf8c15189e568e8185b8c278cfa49e751dc1061/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/acf8c15189e568e8185b8c278cfa49e751dc1061/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/acf8c15189e568e8185b8c278cfa49e751dc1061/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/acf8c15189e568e8185b8c278cfa49e751dc1061/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/acf8c15189e568e8185b8c278cfa49e751dc1061/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/acf8c15189e568e8185b8c278cfa49e751dc1061/chrome/browser/ui/webui/settings/site_settings_handler.h
[modify] https://crrev.com/acf8c15189e568e8185b8c278cfa49e751dc1061/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/acf8c15189e568e8185b8c278cfa49e751dc1061/chrome/browser/ui/webui/site_settings_helper.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/949a29bda77e1743a52bf79e45046b17e28f3d3c

commit 949a29bda77e1743a52bf79e45046b17e28f3d3c
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Sep 16 18:12:36 2016

[MD settings] Page title in site details through direct link

This CL moves some code from site_lists.js to site_settings_behavior.js
so that it can be used from site_details.js. As a result, we can
complete the initialization of the SiteException received in
site_details.js and show the URL in that UI.

BUG= 635874 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338133008
Cr-Commit-Position: refs/heads/master@{#419216}

[modify] https://crrev.com/949a29bda77e1743a52bf79e45046b17e28f3d3c/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/949a29bda77e1743a52bf79e45046b17e28f3d3c/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/949a29bda77e1743a52bf79e45046b17e28f3d3c/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

Status: Fixed (was: Started)

Sign in to add a comment