New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635873 link

Starred by 2 users
Status: Fixed
Owner:
msramek@chromium.org
Closed: Sep 2016
Cc:
msarda@chromium.org
█ ioanap@google.com
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 620317


Sign in to add a comment

Code cleanup: Merge browsing_data_ui into browsing_data

Project Member Reported by msramek@chromium.org, Aug 9 2016 
//components/browsing_data_ui was added in the context of  issue 595332  to introduce UI functionality shared between the Clear Browsing Data dialog in //chrome and //ios.

In the meantime, we have started componentizing more of //chrome/browser/browsing_data/ in issue 620317. //components/browsing_data is now a layered component that contains both common logic and UI functionality for the Clear Browsing Data dialog.

The semantic differences between the two components are now minimal. Whoever wants to include one of them will typically want the other, and whoever wants to add a new feature will be confused on which component to choose.

We should merge browsing_data_ui into browsing_data.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e

commit c153a25112aa4aa30eacac463c1fc0b2d9b4f52e
Author: msramek <msramek@chromium.org>
Date: Mon Sep 19 14:18:27 2016

Merge //components/browsing_data_ui into //components/browsing_data/core

The component browsing_data_ui contains code used by the Clear Browsing
Data dialog on all platforms. It was created because there was no other
component fitting that purpose.

However, the browsing_data component has been recently made into a layered
component (https://codereview.chromium.org/2127403002), providing various
browsing data related functionality for all platforms.

Since the two components have basically the same purpose and confusingly
similar names, we merge them into one.

TBR=dbeam@chromium.org
BUG= 635873 

Review-Url: https://codereview.chromium.org/2238453002
Cr-Commit-Position: refs/heads/master@{#419450}

[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/chrome/browser/ui/webui/history_ui.cc
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/components/BUILD.gn
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/components/browsing_data/core/BUILD.gn
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/components/browsing_data/core/DEPS
[add] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/components/browsing_data/core/OWNERS
[rename] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/components/browsing_data/core/history_notice_utils.cc
[rename] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/components/browsing_data/core/history_notice_utils.h
[rename] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/components/browsing_data/core/history_notice_utils_unittest.cc
[delete] https://crrev.com/1ce4ff3d8c73bfd77e7f8d0135134f2524b4d480/components/browsing_data_ui/BUILD.gn
[delete] https://crrev.com/1ce4ff3d8c73bfd77e7f8d0135134f2524b4d480/components/browsing_data_ui/OWNERS
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/ios/chrome/browser/DEPS
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/ios/chrome/browser/ui/webui/history/browsing_history_handler.cc
[modify] https://crrev.com/c153a25112aa4aa30eacac463c1fc0b2d9b4f52e/ios/chrome/browser/ui/webui/history/history_ui.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a765fb3e033592f5cfaea2a29f088622a66d62b3

commit a765fb3e033592f5cfaea2a29f088622a66d62b3
Author: msramek <msramek@chromium.org>
Date: Tue Sep 27 14:29:12 2016

Remove the unused browsing_data_ui/ component.

Its contents were moved to the browsing_data/ component in
https://codereview.chromium.org/2238453002, but the directory itself
and the DEPS file in it were accidentally left behind.

BUG= 635873 

Review-Url: https://codereview.chromium.org/2372223002
Cr-Commit-Position: refs/heads/master@{#421199}

[delete] https://crrev.com/20ebca037955834a66e956a2dae71daef7884d25/components/browsing_data_ui/DEPS

Comment 3 by msramek@chromium.org, Sep 27 2016

Status: Fixed (was: Assigned)
This is now finished, including the iOS counterpart.
►

Sign in to add a comment