New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635862 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Feature

Blocking:
issue 614277



Sign in to add a comment

MD Site Settings: Site List -- Show incognito entries

Project Member Reported by finnur@chromium.org, Aug 9 2016

Issue description

Tom Buckley requested we show when entry in the Site List apply to current incognito session only.
 
Owner: finnur@chromium.org
Status: Started (was: Untriaged)
This is also a part of the CL that is in review.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3

commit 1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3
Author: finnur <finnur@chromium.org>
Date: Mon Sep 05 12:29:20 2016

Site Settings Desktop: Support adding exceptions for incognito mode.

BUG= 635855 ,  635862 ,  614277 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2298283002
Cr-Commit-Position: refs/heads/master@{#416534}

[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/app/settings_strings.grdp
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/settings/site_settings_handler.h
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/site_settings_helper.h
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/test/base/testing_profile.h
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js

Status: Fixed (was: Started)

Sign in to add a comment