New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635852 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 614277



Sign in to add a comment

MD Site Settings: Implement Remove for Cookie Data list

Project Member Reported by finnur@chromium.org, Aug 9 2016

Issue description

The mocks for the list of all cookie data show a top level RemoveAll and a Remove icon after each item in the list. This needs to be implemented.

 

Comment 1 by finnur@chromium.org, Aug 17 2016

Owner: finnur@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f40c843852d50fc41aa353588d7799f0f6203626

commit f40c843852d50fc41aa353588d7799f0f6203626
Author: finnur <finnur@chromium.org>
Date: Fri Aug 19 15:27:52 2016

Site Settings Desktop: Implement individual cookie removal and RemoveAll.

BUG= 635852 ,  614277 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2248683006
Cr-Commit-Position: refs/heads/master@{#413151}

[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/cookie_tree_node.js
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/site_data.js
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/ui/webui/settings/settings_cookies_view_handler.h

Comment 3 by finnur@chromium.org, Aug 23 2016

Status: Fixed (was: Started)

Sign in to add a comment