New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635850 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Feature

Blocking:
issue 614277



Sign in to add a comment

MD Site Settings: Add missing links to Cookies UI

Project Member Reported by finnur@chromium.org, Aug 9 2016

Issue description

The Cookies UI is missing a couple of links:
- Adobe Flash Player Storage Settings
- Learn More

 
Labels: -Type-Bug Type-Feature

Comment 2 by finnur@chromium.org, Aug 16 2016

Cc: rolfe@chromium.org
Rebecca, re: The Adobe Flash Player Storage Settings link that I see in the mocks.

I don't see that in the old UI and I'm not sure where it should point. Got any tips for me?

Comment 3 by rolfe@chromium.org, Aug 16 2016

Hey finnur@: It's CrOS-only. Screengrab attached. It links here: https://www.macromedia.com/support/documentation/en/flashplayer/help/settings_manager07.html
Screen Shot 2016-08-16 at 8.37.16 AM.png
124 KB View Download

Comment 4 by finnur@chromium.org, Aug 22 2016

Follow-up questions for Rebecca and FYI for Dave, who's probably going to review it... :)

1) The destination for the Learn More link is a general "how to manage exceptions" page on the help center. That implies that the Learn More button should appear on all categories, not just cookies. The Adobe link, however, only applies to Cookies. Is it OK if the left area of the Learn More button is blank for categories other than cookies? (see image 1 -- Location category)

2) Both of those are links that point to an external site and the old UI treats them as such (simply hyperlinks). The new mocks, however, don't show these as links -- The Adobe link looks like a menu entry that you can click on and the Learn More link looks like a (secondary) button. To make matters more confusing (for the user), the Site Category page also has links, which are blue, but they actually don't point to an external site (point to Add Exception dialog). See image 2 (Cookies category). I'd like if we could come up with a solution that would pass both UI review and code review. Can we hash that out here? :)
Screenshot from 2016-08-22 15:26:46.png
21.6 KB View Download
Screenshot from 2016-08-22 15:26:09.png
26.6 KB View Download

Comment 5 by finnur@chromium.org, Aug 23 2016

What say you, Rebecca?

Comment 6 by rolfe@chromium.org, Aug 23 2016

Cc: tbuck...@chromium.org bettes@chromium.org finnur@chromium.org
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)
Apologies for the delay.

+bettes@ did the final polish so hoping he can add his reasoning here.

I'd think that "learn more" should not exist by itself on the right (but instead look like the one in the Zoom levels card: https://drive.google.com/a/google.com/file/d/0BxMIIGI80eU-WmxwNl9Eby1hSUk/view)

Alan - could we do something like:
<a>Adobe Flash Player Settings </a> | <a>Learn more</a>

The Flash settings only appear on CrOS and so won't be common across desktop. When they don't appear, Learn more can just slide over. Work for you?

Comment 7 by finnur@chromium.org, Aug 25 2016

Fine with me. Alan?

Comment 9 by finnur@chromium.org, Aug 29 2016

Status: Fixed (was: Assigned)
Followed Rebecca's suggestion. Shouldn't be hard to change, if need be -- but unless I hear otherwise, I'll assume this fixed.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40e215ad73339ab39c468105c31cc056906d3e01

commit 40e215ad73339ab39c468105c31cc056906d3e01
Author: finnur <finnur@chromium.org>
Date: Mon Sep 19 11:13:41 2016

Site Settings Desktop: Minor fix.

Use preprocess=true instead of flattenhtml and allowexternalscript.

BUG= 635850 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2344203002
Cr-Commit-Position: refs/heads/master@{#419429}

[modify] https://crrev.com/40e215ad73339ab39c468105c31cc056906d3e01/chrome/browser/resources/settings/settings_resources.grd

Sign in to add a comment