MD Site Settings: Add missing links to Cookies UI |
||||
Issue descriptionThe Cookies UI is missing a couple of links: - Adobe Flash Player Storage Settings - Learn More
,
Aug 16 2016
Rebecca, re: The Adobe Flash Player Storage Settings link that I see in the mocks. I don't see that in the old UI and I'm not sure where it should point. Got any tips for me?
,
Aug 16 2016
Hey finnur@: It's CrOS-only. Screengrab attached. It links here: https://www.macromedia.com/support/documentation/en/flashplayer/help/settings_manager07.html
,
Aug 22 2016
Follow-up questions for Rebecca and FYI for Dave, who's probably going to review it... :) 1) The destination for the Learn More link is a general "how to manage exceptions" page on the help center. That implies that the Learn More button should appear on all categories, not just cookies. The Adobe link, however, only applies to Cookies. Is it OK if the left area of the Learn More button is blank for categories other than cookies? (see image 1 -- Location category) 2) Both of those are links that point to an external site and the old UI treats them as such (simply hyperlinks). The new mocks, however, don't show these as links -- The Adobe link looks like a menu entry that you can click on and the Learn More link looks like a (secondary) button. To make matters more confusing (for the user), the Site Category page also has links, which are blue, but they actually don't point to an external site (point to Add Exception dialog). See image 2 (Cookies category). I'd like if we could come up with a solution that would pass both UI review and code review. Can we hash that out here? :)
,
Aug 23 2016
What say you, Rebecca?
,
Aug 23 2016
Apologies for the delay. +bettes@ did the final polish so hoping he can add his reasoning here. I'd think that "learn more" should not exist by itself on the right (but instead look like the one in the Zoom levels card: https://drive.google.com/a/google.com/file/d/0BxMIIGI80eU-WmxwNl9Eby1hSUk/view) Alan - could we do something like: <a>Adobe Flash Player Settings </a> | <a>Learn more</a> The Flash settings only appear on CrOS and so won't be common across desktop. When they don't appear, Learn more can just slide over. Work for you?
,
Aug 25 2016
Fine with me. Alan?
,
Aug 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcf428ae8f05ccb8c936128c84565d44ccdc2fc8 commit dcf428ae8f05ccb8c936128c84565d44ccdc2fc8 Author: finnur <finnur@chromium.org> Date: Mon Aug 29 14:02:20 2016 Site Settings Desktop: Add links to Adobe settings and Learn more. Adobe Flash settings are for ChromeOS only. Learn More for all categories. BUG= 635850 , 614277 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2272213005 Cr-Commit-Position: refs/heads/master@{#415003} [modify] https://crrev.com/dcf428ae8f05ccb8c936128c84565d44ccdc2fc8/chrome/app/settings_strings.grdp [modify] https://crrev.com/dcf428ae8f05ccb8c936128c84565d44ccdc2fc8/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/dcf428ae8f05ccb8c936128c84565d44ccdc2fc8/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/dcf428ae8f05ccb8c936128c84565d44ccdc2fc8/chrome/browser/resources/settings/site_settings/site_settings_category.html [modify] https://crrev.com/dcf428ae8f05ccb8c936128c84565d44ccdc2fc8/chrome/browser/resources/settings/site_settings/site_settings_category.js [modify] https://crrev.com/dcf428ae8f05ccb8c936128c84565d44ccdc2fc8/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Aug 29 2016
Followed Rebecca's suggestion. Shouldn't be hard to change, if need be -- but unless I hear otherwise, I'll assume this fixed.
,
Sep 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40e215ad73339ab39c468105c31cc056906d3e01 commit 40e215ad73339ab39c468105c31cc056906d3e01 Author: finnur <finnur@chromium.org> Date: Mon Sep 19 11:13:41 2016 Site Settings Desktop: Minor fix. Use preprocess=true instead of flattenhtml and allowexternalscript. BUG= 635850 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2344203002 Cr-Commit-Position: refs/heads/master@{#419429} [modify] https://crrev.com/40e215ad73339ab39c468105c31cc056906d3e01/chrome/browser/resources/settings/settings_resources.grd |
||||
►
Sign in to add a comment |
||||
Comment 1 by finnur@chromium.org
, Aug 9 2016