New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635836 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: In bookmarks bar, unnecessary tooltip is seen for folders with small name.

Reported by vvishwak...@etouch.net, Aug 9 2016

Issue description

Version: 54.0.2824.0 (Official Build) facabd3224aecbcab4bea9daadad31c67488d78c-refs/heads/master@{#410520} (64-bit)
OS: Mac (10.10.5, 10.11.5)

What steps will reproduce the problem?
1) Launch chrome, go to NTP and add a ‘New folder’ on Bookmarks bar.
2) Create another folder inside the already created folder.
3) Now click on ‘New folder’ in bookmarks bar and mouse hover on the folder inside it.

When mouse hovered on ‘New folder’, unnecessary tooltip is seen.

Tooltip should be seen only for folders with big names.

This is a Regression issue broken in M-49, below is the bisect info 
Manual bisect:
Good build: 49.0.2573.0
Bad build: 49.0.2574.0

Narrow bisect URL:
https://chromium.googlesource.com/chromium/src/+log/6ccf5fd5ca8ee56e0de7f1b768a7e904662edc85..68cf0b8360a8ea1dbcd5efb524e7831e1c22bd66?pretty=fuller&n=10000

Suspecting: r361388

Note: Issue is not seen on Windows and Linux OS.
 
bookmark_actual.mov
4.4 MB Download
bookmark_expected.mov
3.2 MB Download
Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Assigned)
I'm going to mark this Pri-3.

Since we're using NSMenuItem for these menus, there's no good way for us to tell whether the item is getting elided or not, which makes it complex to tell whether there "should be" a tooltip or not. The unnecessary tooltips shouldn't be there, but I don't think this has a good importance-to-effort ratio.
Labels: Needs-Feedback
This bug is tagged as regression.Which means that the bisects are incorrect or do not have an owner who is actively investigating.
Requesting the reporter to triage and update the behavior in all the latest chrome channels and bisect if needed.Close as WontFix if not reproducible.

Comment 3 by coron...@gmail.com, Nov 16 2016

I will handle this issue.

Comment 4 by coron...@gmail.com, Nov 16 2016

I upload CL for this issue. (https://codereview.chromium.org/2504753003/)
I also upload screen shot to show how it works.
short_name.png
146 KB View Download
long_name.png
137 KB View Download

Comment 6 by rsesek@chromium.org, Nov 21 2016

Status: Fixed (was: Available)
Thanks for the patch!

Sign in to add a comment