New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635824 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 633182
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

regression in system_health.memory_mobile at 408616:408625

Project Member Reported by petrcermak@chromium.org, Aug 9 2016

Issue description

Summary: regression in system_health.memory_mobile at 408616:408625 (was: regression in system_health.memory_mobile at 408616:408626)
Mergedinto: 633182
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland: Web MIDI: use mojom::blink::PermissionService directly to ask permission
Author  : toyoshim
Commit description:
  
Changes from the first attempt:

- AwPermissionManager::RequestPermissions() was implemented for
  Android WebView in a separate CL.
- Workarounds to avoid touching NOTIMPLEMENTED() was removed

Original description follows:

SystemWebViewShellLayoutTest failed because of the same reason with
other modified tests in this CL. Tests are modified to pass, but now
it does not cover {sysex:true} case that needs
AwPermissionManager::RequestPermissions implementation.
It will be implemented in the next CL soon.

Original description follows:
Web MIDI asked permissions via public/web interfaces.
But now that PermissionService is available in Blink,
use the service to ask permissions.

This migration makes it possible to remove all MIDI
related public/web interfaces.

BUG=582328

Committed: https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc
Cr-Commit-Position: refs/heads/master@{#404136}

TEST=${OUT}/bin/run_system_webview_shell_layout_test_apk # with a built SystemWebViewGoogle.apk
TEST=git cl try

Review-Url: https://codereview.chromium.org/2116763002
Cr-Commit-Position: refs/heads/master@{#408621}
Commit  : 8c21bb977b580edb009eb2fe0d3f511fd5ca42f4
Date    : Fri Jul 29 12:28:28 2016


===== TESTED REVISIONS =====
Revision         Mean    Std Dev  N  Good?
chromium@408616  864256  0.0      5  good
chromium@408619  864256  0.0      5  good
chromium@408620  864256  0.0      5  good
chromium@408621  876544  0.0      5  bad    <--
chromium@408625  876544  0.0      5  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 635824

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_mobile
Test Metric: load_games-memory:chrome:all_processes:reported_by_os:system_memory:ashmem:private_dirty_size_avg/load_games_lazors
Relative Change: 1.42%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/902
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004811542003143568


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5338375557480448

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Labels: SystemHealth-Sheriff
Labels: -Performance-Sheriff

Sign in to add a comment