Add a flag to allow origin trial tokens signed with the test key |
||||||
Issue descriptionIt is helpful for both feature developers and web developers to be able to test with the test origin trial key (generated by generate_token.py, as documented here: https://github.com/jpchase/OriginTrials/blob/gh-pages/ship-as-trial.md). However, it's currently quite hard to have Chrome (the browser, as opposed to the test suite) accept tokens signed with this key. You currently have two options: 1. Use the command-line switch "--origin-trial-public-key=dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNA=". This is a base-64-encoding of the test public key in trial_token_unittest.cc, but it is hard to discover, and is an implementation detail. It's also hard or impossible to do this on platforms that don't take command-line arguments (e.g., Chrome OS, Android). 2. Modify chrome_origin_trial_policy.cc, replacing the public key there with the test public key. There should be a flag --origin-trial-use-test-key which is an alias for the above --origin-trial-public-key. This would be much easier to use and could be enabled from the chrome://flags panel. It would also be nice if this would be in addition to the default public key, rather than instead of (see Issue 584737).
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b9774cf8fb53ada294e332a77111ce1f92ab9a1 commit 3b9774cf8fb53ada294e332a77111ce1f92ab9a1 Author: mgiuca <mgiuca@chromium.org> Date: Wed Aug 10 06:32:26 2016 trial_token_unittest: Document how to use or update the public key. Provides instruction for anyone changing the test public/private key pair that they have to update the corresponding private key file. Also provides a comment with the base-64-encoded public key, so we can instruct users how to use this key from the command line. BUG=635791 Review-Url: https://codereview.chromium.org/2226213002 Cr-Commit-Position: refs/heads/master@{#410982} [modify] https://crrev.com/3b9774cf8fb53ada294e332a77111ce1f92ab9a1/content/common/origin_trials/trial_token_unittest.cc
,
Aug 10 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 10 2017
,
Aug 16 2017
,
Aug 20
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 20
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by iclell...@chromium.org
, Aug 9 2016