New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635790 link

Starred by 1 user
Status: Fixed
Owner:
tkent@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
dbeam@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Overlapping issue is observed in search field of 'chrome://downloads'

Reported by dmascare...@etouch.net, Aug 9 2016 
Chrome Version:54.0.2824.0 facabd3224aecbcab4bea9daadad31c67488d78c-refs/heads/master@{#410520} (64-bit)
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://downloads/
2. Click on Search field and change the writing direction from 'Right to Left', type some text.
3. Observe.

Actual: Overlapping of text and close icon is seen.
Expected: Overlapping should not be seen.

This is regression issue, broken in 'M 54' and will soon update the bisect info:

Comment 1 by dmascare...@etouch.net, Aug 9 2016

Labels: hasbisect OS-Mac
Owner: tkent@chromium.org
Status: Assigned (was: Untriaged)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/ad8b34b93f28c3c66417d9d15c110f4e77d0c97d..7017637cecdd300f3a90f6afbde474ea4a98a418?pretty=fuller&n=10000

Suspecting: r410495

Good build:54.0.2823.0
Bad build:54.0.2824.0

Note: Issue is also reproducible on Mac OS.
download.png
8.1 KB View Download

Comment 2 by ranjitkan@chromium.org, Aug 9 2016

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 3 by tkent@chromium.org, Aug 9 2016

Cc: dbeam@chromium.org
Labels: -Pri-1 Pri-2
The 'Right to Left' menu action adds dir=rtl to the INPUT element.  The Blink behavior is correct.  We need to update WebUI code.

Comment 4 by dbeam@chromium.org, Aug 10 2016

Labels: -Pri-2 Pri-3

Comment 5 by tkent@chromium.org, Aug 10 2016

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e5ce8b8b6563ad06c752d8cc767c927ad764693

commit 2e5ce8b8b6563ad06c752d8cc767c927ad764693
Author: tkent <tkent@chromium.org>
Date: Wed Aug 17 00:04:14 2016

chrome://downloads: Fix a regression by RTL-aware input[type=search].

Secure space for paper-icon-button at the right side if the document is LTR, and
at the left side if the document is RTL, regardless of the direction of
input[type=search].

::-webkit-search-cancel-button has never worked in chrome://downloads because
its size was 20px x 0px. So this CL removes it by dislay:none, and secure space
by padding.

BUG= 635790 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2227373002
Cr-Commit-Position: refs/heads/master@{#412389}

[modify] https://crrev.com/2e5ce8b8b6563ad06c752d8cc767c927ad764693/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/2e5ce8b8b6563ad06c752d8cc767c927ad764693/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.css

Comment 7 by tkent@chromium.org, Aug 18 2016

Status: Fixed (was: Started)

Comment 8 by ssamanoori@chromium.org, Aug 19 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2832.2
Tested the issue on Windows 7, Mac 10.11.6 using 54.0.2832.2.Overlapping of text and close icon is not seen.
Please find attached screenshot.

Marking it as TE-Verified.
635790.png
39.2 KB View Download
►

Sign in to add a comment