New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635787 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Integer-overflow in SkXfermodeImageFilter::filterImageGPU

Project Member Reported by ClusterFuzz, Aug 9 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4957986734997504

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  SkXfermodeImageFilter::filterImageGPU
  SkXfermodeImageFilter::onFilterImage
  SkImageFilter::filterImage
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=398502:398570

Minimized Testcase (129.69 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96t4Fz91X3g2ghzqXh9q0PRq6-pVG1f7gSk04OWjTKEIAUPK8394cbythhE-f0dFCtZd9QVeztwVkcLekOuJFi3dKoS_jQhXh6vr03Q-YTubW5tMqdRqsbDP1yakbh55pq-fyRhPkAgVlmI8mFop6cNIVbqMDK3TPLv6BV6YHYjkNCtrvM?testcase_id=4957986734997504

Issue manually filed by: nyerramilli

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: nyerramilli@chromium.org reed@chromium.org
Components: Tools>Test>FindIt>WrongResult
Labels: findit-wrong Te-Logged M-53
Owner: bsalomon@chromium.org
Status: Assigned (was: Untriaged)
assigning to skia team https://cs.chromium.org/chromium/src/third_party/skia/OWNERS
reed@/ bsalomon@ - Could you please check the above issue & help us in finding an owner it its not yours.

providing Findit results for internal purpose:
Suspected CLs	No CL in the regression range changes the crashed files. The result is the blame information.

Author: robertphillips
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/4f0379444db31421894d2fce7c85889fe5eaa01a
Time: Tue Feb 09 13:09:27 2016
The CL last changed line 189 of file SkXfermodeImageFilter.cpp, which is stack frame 0.

Author: robertphillips
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/f230c6d979d7035cbf6995da8a0161e7802b92b7
Time: Fri Apr 15 19:47:42 2016
The CL last changed line 90 of file SkXfermodeImageFilter.cpp, which is stack frame 1.

Author: robertphillips
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/2302de920e5434809bd0e85b871a6e002856dfdb
Time: Thu Mar 24 14:26:32 2016
The CL last changed line 212 of file SkImageFilter.cpp, which is stack frame 2.

Author: robertphillips
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/2302de920e5434809bd0e85b871a6e002856dfdb
Time: Thu Mar 24 14:26:32 2016
The CL last changed line 442 of file SkImageFilter.cpp, which is stack frame 3.

Author: robertphillips
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/ae2f2de1b85e35824aab13f11e082920a33805ad
Time: Wed Mar 23 11:40:01 2016
The CL last changed line 49 of file SkLocalMatrixImageFilter.cpp, which is stack frame 4.

Author: robertphillips
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/2302de920e5434809bd0e85b871a6e002856dfdb
Time: Thu Mar 24 14:26:32 2016
The CL last changed line 212 of file SkImageFilter.cpp, which is stack frame 5.

Author: senorblanco
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/5878dbdf1b5d86201d299c6e07d53e35048713c7
Time: Thu May 19 21:50:29 2016
The CL last changed line 362 of file SkImage.cpp, which is stack frame 6.

Suspected Project: chromium-skia
Suspected Component: Internals>Skia
Cc: bsalomon@chromium.org
Owner: robertphillips@chromium.org
Cc: robertph...@google.com
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a501196b86e2c17e53fc2c76188e803d4f882e4

commit 8a501196b86e2c17e53fc2c76188e803d4f882e4
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Wed Aug 17 17:32:28 2016

Roll src/third_party/skia/ d24ee1419..8d3f92a92 (5 commits).

https://chromium.googlesource.com/skia.git/+log/d24ee1419f17..8d3f92a92be7

$ git log d24ee1419..8d3f92a92 --date=short --no-merges --format='%ad %ae %s'
2016-08-17 csmartdalton Make GrReducedClip's gen ID only apply to the element list
2016-08-17 robertphillips Kick the can down the road a bit w.r.t. fuzzer complaint
2016-08-17 bsalomon Fix tile bitmap code in SkGpuDevice to compute correct local coords.
2016-08-17 bsalomon Minor cleanup of GP classes in GrOvalRenderer
2016-08-17 msarett Modify SkPngCodec to recognize 565 images from the sBIT chunk

BUG= 635787 

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2251113002
Cr-Commit-Position: refs/heads/master@{#412575}

[modify] https://crrev.com/8a501196b86e2c17e53fc2c76188e803d4f882e4/DEPS

Project Member

Comment 6 by ClusterFuzz, Aug 18 2016

ClusterFuzz has detected this issue as fixed in range 412570:412592.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4957986734997504

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  SkXfermodeImageFilter::filterImageGPU
  SkXfermodeImageFilter::onFilterImage
  SkImageFilter::filterImage
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=398502:398570
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=412570:412592

Minimized Testcase (129.69 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96t4Fz91X3g2ghzqXh9q0PRq6-pVG1f7gSk04OWjTKEIAUPK8394cbythhE-f0dFCtZd9QVeztwVkcLekOuJFi3dKoS_jQhXh6vr03Q-YTubW5tMqdRqsbDP1yakbh55pq-fyRhPkAgVlmI8mFop6cNIVbqMDK3TPLv6BV6YHYjkNCtrvM?testcase_id=4957986734997504

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Aug 18 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Components: -Tools>Test>FindIt>WrongResult
Labels: Test-Predator-Wrong
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment