New issue
Advanced search Search tips

Issue 635785 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

omnibox_edit_model.cc(734) Check failed: !last_omnibox_focus_.is_null()

Project Member Reported by toyoshim@chromium.org, Aug 9 2016

Issue description

I see an assertion failure at trunk build.

Step to reproduce:
 1. navigate to a site
 2. drag site information icon in the omnibox
 3. drop into omnibox itself
 
[15111:15111:0809/162428:FATAL:omnibox_edit_model.cc(734)] Check failed: !last_omnibox_focus_.is_null(). An omnibox focus should have occurred before opening a match.
#0 0x7fb2074853ce base::debug::StackTrace::StackTrace()
#1 0x7fb2074a65eb logging::LogMessage::~LogMessage()
#2 0x7fb2091199ab OmniboxEditModel::OpenMatch()
#3 0x7fb209121daf OmniboxView::OpenMatch()
#4 0x7fb209118c26 OmniboxEditModel::PasteAndGo()
#5 0x7fb208eb2c44 OmniboxViewViews::OnDrop()
#6 0x7fb202af832a views::Textfield::OnPerformDrop()
#7 0x7fb202b189b1 views::DropHelper::OnDrop()
#8 0x7fb202b39eef views::DesktopNativeWidgetAura::OnPerformDrop()
#9 0x7fb202b3d031 views::DesktopDragDropClientAuraX11::OnXdndDrop()
#10 0x7fb202b3e7e8 views::DesktopDragDropClientAuraX11::SendXClientEvent()
#11 0x7fb202b3e1ec views::DesktopDragDropClientAuraX11::OnMouseReleased()
#12 0x7fb202b49e87 views::X11WholeScreenMoveLoop::DispatchEvent()
#13 0x7fb2063c17ef ui::PlatformEventSource::DispatchEvent()
#14 0x7fb2027d63fc ui::X11EventSource::ExtractCookieDataDispatchEvent()
#15 0x7fb2027d632d ui::X11EventSource::DispatchXEvents()
#16 0x7fb2027d9aa9 ui::(anonymous namespace)::XSourceDispatch()
#17 0x7fb20102bce5 g_main_context_dispatch
#18 0x7fb20102c048 <unknown>
#19 0x7fb20102c0ec g_main_context_iteration
#20 0x7fb2074b32e6 base::MessagePumpGlib::Run()
#21 0x7fb2074b09b1 base::MessageLoop::RunHandler()
#22 0x7fb2074df180 base::RunLoop::Run()
#23 0x7fb202b4a2d4 views::X11WholeScreenMoveLoop::RunMoveLoop()
#24 0x7fb202b3d53b views::DesktopDragDropClientAuraX11::StartDragAndDrop()
#25 0x7fb202b2e729 views::RunShellDrag()
#26 0x7fb202b1de99 views::Widget::RunShellDrag()
#27 0x7fb202b16b3d views::View::DoDrag()
#28 0x7fb202b14519 views::View::ProcessMouseDragged()
#29 0x7fb202b140b0 views::View::OnMouseEvent()
#30 0x7fb202941ab5 ui::EventDispatcher::ProcessEvent()
#31 0x7fb20294185d ui::EventDispatcherDelegate::DispatchEvent()
#32 0x7fb202b1992e views::internal::RootView::OnMouseDragged()
#33 0x7fb202b39765 views::DesktopNativeWidgetAura::OnMouseEvent()
#34 0x7fb202941ab5 ui::EventDispatcher::ProcessEvent()
#35 0x7fb20294185d ui::EventDispatcherDelegate::DispatchEvent()
#36 0x7fb20294254e ui::EventProcessor::OnEventFromSource()
#37 0x7fb202942a7f ui::EventSource::SendEventToProcessor()
#38 0x7fb202b46b82 views::DesktopWindowTreeHostX11::DispatchMouseEvent()
#39 0x7fb202b47abc views::DesktopWindowTreeHostX11::DispatchEvent()
#40 0x7fb202b47eed views::DesktopWindowTreeHostX11::DispatchEvent()
#41 0x7fb2063c1938 ui::PlatformEventSource::DispatchEvent()
#42 0x7fb2027d63fc ui::X11EventSource::ExtractCookieDataDispatchEvent()
#43 0x7fb2027d632d ui::X11EventSource::DispatchXEvents()
#44 0x7fb2027d9aa9 ui::(anonymous namespace)::XSourceDispatch()
#45 0x7fb20102bce5 g_main_context_dispatch
#46 0x7fb20102c048 <unknown>
#47 0x7fb20102c0ec g_main_context_iteration
#48 0x7fb2074b32e6 base::MessagePumpGlib::Run()
#49 0x7fb2074b09b1 base::MessageLoop::RunHandler()
#50 0x7fb2074df180 base::RunLoop::Run()
#51 0x7fb2084d284a ChromeBrowserMainParts::MainMessageLoopRun()
#52 0x7fb204d93f49 content::BrowserMainLoop::RunMainMessageLoopParts()
#53 0x7fb204d97098 content::BrowserMainRunnerImpl::Run()
#54 0x7fb204d8f97d content::BrowserMain()
#55 0x7fb20567ce64 content::RunNamedProcessTypeMain()
#56 0x7fb20567d8c3 content::ContentMainRunnerImpl::Run()
#57 0x7fb20567c180 content::ContentMain()
#58 0x7fb207eecd5b ChromeMain
#59 0x7fb1fe632f45 __libc_start_main
#60 0x7fb207eecc35 <unknown>

Labels: OS-Chrome OS-Windows
Owner: mpear...@chromium.org
Reproduces on Windows too.

It seems drag-and-drop (from any source) is a case where it's legitimate to not have focus before navigating.  We should probably adjust the code so it doesn't assume a previous focus in that case.

->Mark because I don't know if we need to do anything complicated to ensure that handling this doesn't goof up our metrics.
Status: Assigned (was: Untriaged)
Labels: OS-Mac
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0afef87f6ef1567a88011c97ac86dc09db75256

commit b0afef87f6ef1567a88011c97ac86dc09db75256
Author: mpearson <mpearson@chromium.org>
Date: Fri Aug 12 19:33:36 2016

Omnibox: Remove Overly-Aggressive DCHECK (focus must occur before open)

And revise a related histogram.

BUG= 635785 

Review-Url: https://codereview.chromium.org/2245443002
Cr-Commit-Position: refs/heads/master@{#411733}

[modify] https://crrev.com/b0afef87f6ef1567a88011c97ac86dc09db75256/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/b0afef87f6ef1567a88011c97ac86dc09db75256/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment