omnibox_edit_model.cc(734) Check failed: !last_omnibox_focus_.is_null() |
||||||
Issue descriptionI see an assertion failure at trunk build. Step to reproduce: 1. navigate to a site 2. drag site information icon in the omnibox 3. drop into omnibox itself
,
Aug 9 2016
Reproduces on Windows too. It seems drag-and-drop (from any source) is a case where it's legitimate to not have focus before navigating. We should probably adjust the code so it doesn't assume a previous focus in that case. ->Mark because I don't know if we need to do anything complicated to ensure that handling this doesn't goof up our metrics.
,
Aug 9 2016
,
Aug 9 2016
,
Aug 10 2016
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0afef87f6ef1567a88011c97ac86dc09db75256 commit b0afef87f6ef1567a88011c97ac86dc09db75256 Author: mpearson <mpearson@chromium.org> Date: Fri Aug 12 19:33:36 2016 Omnibox: Remove Overly-Aggressive DCHECK (focus must occur before open) And revise a related histogram. BUG= 635785 Review-Url: https://codereview.chromium.org/2245443002 Cr-Commit-Position: refs/heads/master@{#411733} [modify] https://crrev.com/b0afef87f6ef1567a88011c97ac86dc09db75256/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/b0afef87f6ef1567a88011c97ac86dc09db75256/tools/metrics/histograms/histograms.xml
,
Aug 12 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by toyoshim@chromium.org
, Aug 9 2016