CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/0861c56c582da4866a84104dc5764a8adad84dd6..3320bea50874bdec0367d6a72f7f6edc35259907

Suspecting https://codereview.chromium.org/1995813002 from changelog.

@meacer: Please confirm the issue.

Issue is seen on Mac OS 10.11.5 canary version: 54.0.2824.0 as well.

On Mac Long URL is shown on the bad build where as short URL: www.google.co.in is shown clicking the Lock icon. 

Pretty likely because of my change, but I don't think this is a regression, nor it should be stable blocking. Other long URLs such as data: also break the page info bar. My CL just made it slightly worse for certain URLs such as view-source.

In any case, I'll take a look.

The current bubble looks pretty broken: If you actually try changing a setting using the view-source bubble, a content setting is created with an empty URL.

I'm going to change this so that the bubble only shows a string like "You are viewing page sources" for view-source URLs. There doesn't seem a good reason to show a bubble for the original page URL when view-sourcing that URL.

I have a patch at https://codereview.chromium.org/2232453002/

M53 Stable launch is coming VERY soon.Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix asap so it gets chance to bake in beta before stable promotion later this month. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1feca06c43dba6d9465e9a06370cbab24f5d7fe

commit e1feca06c43dba6d9465e9a06370cbab24f5d7fe
Author: meacer <meacer@chromium.org>
Date: Mon Aug 15 22:04:43 2016

Show a custom message in the page info bubble for view-source URLs

Screenshot: https://drive.google.com/file/d/0B9q2eN9gDoUIMGYyeE85Ynk2VGs/view?usp=sharing

BUG= 635776 
TBR=sdefresne,caitkp

Review-Url: https://codereview.chromium.org/2232453002
Cr-Commit-Position: refs/heads/master@{#412067}

[modify] https://crrev.com/e1feca06c43dba6d9465e9a06370cbab24f5d7fe/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
[modify] https://crrev.com/e1feca06c43dba6d9465e9a06370cbab24f5d7fe/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
[modify] https://crrev.com/e1feca06c43dba6d9465e9a06370cbab24f5d7fe/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
[modify] https://crrev.com/e1feca06c43dba6d9465e9a06370cbab24f5d7fe/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
[modify] https://crrev.com/e1feca06c43dba6d9465e9a06370cbab24f5d7fe/components/pageinfo_strings.grdp

Before we approve merge to M53, Could you please confirm whether this change is baked/verified in Canary and safe to merge?

Canary looks good to me, but there was a string change in the CL. Is that going to be okay for the merge?

(As in, will it be properly picked up by translators?)

+ tinazh@ to take her opinion on string change as we already pass string freeze deadline (06/17/16).

+ ryanm@, LPM contact

After chatting with ryanm@, string change will be picked up so approving merge to M53 branch 2785. Please merge ASAP. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebad76f9dca81e996a83744e43b7076c2e327e9f

commit ebad76f9dca81e996a83744e43b7076c2e327e9f
Author: Mustafa Acer <meacer@chromium.org>
Date: Tue Aug 16 18:51:00 2016

Show a custom message in the page info bubble for view-source URLs

Screenshot: https://drive.google.com/file/d/0B9q2eN9gDoUIMGYyeE85Ynk2VGs/view?usp=sharing

BUG= 635776 
TBR=sdefresne,caitkp

(cherry picked from commit e1feca06c43dba6d9465e9a06370cbab24f5d7fe)

Review-Url: https://codereview.chromium.org/2232453002
Cr-Original-Commit-Position: refs/heads/master@{#412067}
Cr-Commit-Position: refs/branch-heads/2785@{#628}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/ebad76f9dca81e996a83744e43b7076c2e327e9f/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h
[modify] https://crrev.com/ebad76f9dca81e996a83744e43b7076c2e327e9f/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
[modify] https://crrev.com/ebad76f9dca81e996a83744e43b7076c2e327e9f/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
[modify] https://crrev.com/ebad76f9dca81e996a83744e43b7076c2e327e9f/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
[modify] https://crrev.com/ebad76f9dca81e996a83744e43b7076c2e327e9f/components/pageinfo_strings.grdp

Missing string translation is tracked under bug 638369

Tested the issue on Windows 7, Mac 10.11.6, Ubuntu 14.04 using 53.0.2785.70 as per bugdroid comment #18.A custom message in the page info bubble is shown for view-source URLs.
Please find attached screenshot.

Marking it as TE-Verified.

Deleted: 635776.png 187 KB

	635776.png 187 KB View Download