This is a failing DCHECK(!client_info || base::IsValidGUID(client_info->client_id)) in metrics_state_manager.cc

I can't see any recent changes that would be obvious causes, and this test is already disabled in some cases, see issue 131094,  issue 411251  and issue 368525.

asvitkine@, this test doesn't seem to be in great shape, can you PTAL at this and perhaps also the other reasons that this test is disabled?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5445ce1c75599a59781e686303627dfa468e47a

commit a5445ce1c75599a59781e686303627dfa468e47a
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Tue Aug 09 08:11:16 2016

Disable MetricsServiceBrowserTest.CrashRenderers on Windows

The final DCHECK in MetricsStateManager::LoadClientInfoAndMaybeMigrate
is failing flakily.

BUG= 635770 
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/2223353003 .

Cr-Commit-Position: refs/heads/master@{#410613}

[modify] https://crrev.com/a5445ce1c75599a59781e686303627dfa468e47a/chrome/browser/metrics/metrics_service_browsertest.cc

Here's also the backtrace for when the logs get deleted:

MetricsServiceBrowserTest.CrashRenderers (run #1):
[ RUN      ] MetricsServiceBrowserTest.CrashRenderers
[1672:4840:0808/194135:FATAL:metrics_state_manager.cc(260)] Check failed: !client_info || base::IsValidGUID(client_info->client_id).
Backtrace:
	base::debug::StackTrace::StackTrace [0x01AB0267+23]
	logging::LogMessage::~LogMessage [0x01A6A971+49]
	metrics::MetricsStateManager::LoadClientInfoAndMaybeMigrate [0x02529991+439]
	metrics::MetricsStateManager::ForceClientIdCreation [0x0252958C+132]
	metrics::MetricsService::EnableRecording [0x02522A81+119]
	metrics::MetricsService::StartRecordingForTests [0x02524988+15]
	metrics_services_manager::MetricsServicesManager::UpdatePermissions [0x0311B2CA+102]
	metrics_services_manager::MetricsServicesManager::UpdateUploadPermissions [0x0311B3B1+28]
	ChromeBrowserMainParts::StartMetricsRecording [0x01D30FDE+139]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x01D2F5BF+546]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x01D2F365+164]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x00D40D5A+112]
	content::StartupTaskRunner::RunAllTasksNow [0x00F6393A+27]
	content::BrowserMainLoop::CreateStartupTasks [0x00D3F118+387]
	content::BrowserMainRunnerImpl::Initialize [0x00D41FD1+644]
	content::BrowserMain [0x00D3DE20+153]
	content::RunNamedProcessTypeMain [0x01A53C41+206]
	content::ContentMainRunnerImpl::Run [0x01A53B42+274]
	content::ContentMain [0x01A52EF6+35]
	content::BrowserTestBase::SetUp [0x01DFA011+945]
	InProcessBrowserTest::SetUp [0x01AF74D2+246]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x021C90A1+32]
	testing::Test::Run [0x021CFDC9+51]
	testing::TestCase::Run [0x021CFE9F+133]
	testing::internal::UnitTestImpl::RunAllTests [0x021D021F+434]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x021C90E5+32]
	testing::UnitTest::Run [0x021D0048+133]
	base::TestSuite::Run [0x01AFFC93+95]
	ChromeTestSuiteRunner::RunTestSuite [0x04080130+40]
	content::LaunchTests [0x01DF428E+592]
	LaunchChromeTests [0x04080103+49]
	main [0x0407EDA9+94]
	__scrt_common_main_seh [0x0404448C+255] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:255)
	BaseThreadInitThunk [0x757E338A+18]
	RtlInitializeExceptionChain [0x77559F72+99]
	RtlInitializeExceptionChain [0x77559F45+54]

See analysis @ https://bugs.chromium.org/p/chromium/issues/detail?id=635255#c5 (should probably dupe but not same bots so leaving open for asvitkine to sort out).

Right, same bug. Given the other bug is now fixed, reverting the disable CL.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/192808d9c44b9323ca407186a0b4b5504f34f392

commit 192808d9c44b9323ca407186a0b4b5504f34f392
Author: asvitkine <asvitkine@chromium.org>
Date: Sat Aug 13 00:47:19 2016

Revert of Disable MetricsServiceBrowserTest.CrashRenderers on Windows (patchset #1 id:1 of https://codereview.chromium.org/2223353003/ )

Reason for revert:
Re-enabling test given the underlying issue has
been fixed.

Original issue's description:
> Disable MetricsServiceBrowserTest.CrashRenderers on Windows
>
> The final DCHECK in MetricsStateManager::LoadClientInfoAndMaybeMigrate
> is failing flakily.
>
> BUG= 635770 
> TBR=asvitkine@chromium.org
>
> Committed: https://crrev.com/a5445ce1c75599a59781e686303627dfa468e47a
> Cr-Commit-Position: refs/heads/master@{#410613}

TBR=foolip@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 635770 

Review-Url: https://codereview.chromium.org/2245483006
Cr-Commit-Position: refs/heads/master@{#411836}

[modify] https://crrev.com/192808d9c44b9323ca407186a0b4b5504f34f392/chrome/browser/metrics/metrics_service_browsertest.cc