New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635769 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] 'Network throttling profiles' overlay does not get opened after clicking on 'Add' option for second time.

Reported by rk...@etouch.net, Aug 9 2016

Issue description

Chrome Version: 54.0.2824.0 Revision facabd3224aecbcab4bea9daadad31c67488d78c-refs/heads/master@{#410520}(32/64 bit) 
OS: Windows(7,8,10)

What steps will reproduce the problem?
(1) Launch chrome, open dev tools and press 'Esc' key to open 'Network conditions' section.
(2) Click on No throttling drop down nd click on Add option(Network throttling profiles overlay opened)
(3) Close that overlay and again click on Add option and observe.

Actual: Network throttling profiles overlay does not get opened after clicking on 'Add' option.

Expected: Network throttling profiles overlay should get open after clicking on 'Add' option.

This is a regression issue, broken in 'M-54' will soon update the other info:
 
 

Comment 1 by rk...@etouch.net, Aug 9 2016

Cc: pfeldman@chromium.org mstarzinger@chromium.org
Labels: hasbisect OS-Linux
Owner: jochen@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build: 54.0.2817.0
Bad Build: 54.0.2820.0

Narrow Bisect:
https://chromium.googlesource.com/v8/v8/+log/a719c1ef..9caf4fbd?pretty=fuller&n=10

Suspecting: r38277 ?

Note: Issue is not seen on Mac OS.
Actual_Devtools.mp4
589 KB View Download
Expected_Devtools.mp4
346 KB View Download
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.
Able to reproduce the issue on Windows-10 chrome latest canary M54-54.0.2830.0.

jochen@ - Any update on this bug? Will you mind looking in to it since it's marked as RB-Stable. In case if it's not related to your change please feel free to reassign to the concerned Dev.

Comment 4 by jochen@chromium.org, Aug 22 2016

Owner: brajkumar@chromium.org
I can't reproduce this locally. Also, my change should affect all platforms or none
Labels: Needs-Feedback
Owner: rk...@etouch.net
rkote@ - Will you mind checking this issue? Please check is it repro on latest canary and update the latest behavior of the bug. If issue still persists please rebisect it and update the bug.

Thanks!

Comment 6 by rk...@etouch.net, Aug 30 2016

Cc: brajkumar@chromium.org
Labels: -Needs-Feedback
Owner: jochen@chromium.org
With respect to comment %:

Issue is reproducible on latest canary build: 55.0.2843.0 

Rebisected for the above issue and getting same bisect range i.e:

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+/2527d637a0b563e9c3593aba8652ac8ae77d1055

Suspecting: r409499

@jochen: Please help me to reassign this issue, if your change is not cause for it.
jochen@, Could you please help in reassigning if not related to your change.
Owner: dgozman@chromium.org
@dgozman: Could you please look into this issue.

Thank you.
This issue is marked as Release Block Stable, M54 early stable is scheduled on the first week of October, please plan a fix accordingly.
Cc: dgozman@chromium.org
Owner: jochen@chromium.org
I strongly suspect https://chromium.googlesource.com/v8/v8/+/2f8d4f44257f24e19b3cc98e8ad0de50a457c4cd to be a culprit.

I debugged the problem down to eval call: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/Runtime.js?rcl=0&l=909

In fact, eval'ing on pause works strangely:

<script>
debugger;
</script>

Executing eval("123") in console while paused yields 123.
Executing self.eval("123") yields undefined.

I'm still working on this. The first time the overlay is opened, the promise is created on chrome://devtools, but the second time, when it fails, it's created on about:blank

I don't understand yet where the about:blank frame comes from
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d008b9efcbddf299feefe7b420fd7e1601512ba5

commit d008b9efcbddf299feefe7b420fd7e1601512ba5
Author: jochen <jochen@chromium.org>
Date: Thu Sep 22 13:38:36 2016

Make sure to use the correct context for eval checks

We can't assume that there's no entered context during microtask
execution. We also can't assume that we'll never enter an context during
microtask execution either.

We can however assume that we don't execute microtasks recursively, so
remembering the length of the entered context stack is enough to decide
which context to use.

BUG= chromium:635769 
R=verwaest@chromium.org

Review-Url: https://codereview.chromium.org/2350933007
Cr-Commit-Position: refs/heads/master@{#39627}

[modify] https://crrev.com/d008b9efcbddf299feefe7b420fd7e1601512ba5/src/api.h
[modify] https://crrev.com/d008b9efcbddf299feefe7b420fd7e1601512ba5/src/builtins/builtins.cc

Labels: -OS-Linux -OS-Windows OS-All
Status: Fixed (was: Assigned)
will need to wait for this to roll into chromium and get some canary coverage before merging
Cc: hablich@chromium.org
Labels: Merge-Request-5.4
Michael, ok to merge?

Comment 17 by dimu@chromium.org, Sep 26 2016

Labels: Merge-Review Hotlist-Merge-Review
[Automated comment] No milestone found on Merge-Request (i.e. merge-request-# label).

Comment 18 by dimu@chromium.org, Sep 26 2016

[Automated comment] No milestone found on Merge-Request (i.e. merge-request-# label).

Comment 19 by dimu@chromium.org, Sep 26 2016

[Automated comment] No milestone found on Merge-Request (i.e. merge-request-# label).

Comment 20 by dimu@chromium.org, Sep 26 2016

[Automated comment] No milestone found on Merge-Request (i.e. merge-request-# label).

Comment 21 by dimu@chromium.org, Sep 26 2016

[Automated comment] No milestone found on Merge-Request (i.e. merge-request-# label).

Comment 22 by dimu@chromium.org, Sep 26 2016

[Automated comment] No milestone found on Merge-Request (i.e. merge-request-# label).

Comment 23 by dimu@chromium.org, Sep 26 2016

[Automated comment] No milestone found on Merge-Request (i.e. merge-request-# label).

Comment 24 by dimu@chromium.org, Sep 26 2016

[Automated comment] No milestone found on Merge-Request (i.e. merge-request-# label).

Comment 25 by dimu@chromium.org, Sep 26 2016

[Automated comment] No milestone found on Merge-Request (i.e. merge-request-# label).
Labels: -Merge-Request-5.4 Merge-approved-5.4
The current Canary is broken because of other bugs. I would hold off merging this until we have a good Canary again because of insufficient bake time.
Project Member

Comment 27 by bugdroid1@chromium.org, Sep 27 2016

Labels: merge-merged-5.4
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f1ac92a6f388f707b9eff32690560d5a73d5ee5d

commit f1ac92a6f388f707b9eff32690560d5a73d5ee5d
Author: Jochen Eisinger <jochen@chromium.org>
Date: Tue Sep 27 11:15:44 2016

Merged: Make sure to use the correct context for eval checks

Revision: d008b9efcbddf299feefe7b420fd7e1601512ba5

BUG= chromium:635769 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=hablich@chromium.org

Review URL: https://codereview.chromium.org/2368183005 .

Cr-Commit-Position: refs/branch-heads/5.4@{#59}
Cr-Branched-From: 5ce282769772d94937eb2cb88eb419a6890c8b2d-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49d7b47b40a2d6f74d04d1b76ceae2a0253-refs/heads/master@{#38841}

[modify] https://crrev.com/f1ac92a6f388f707b9eff32690560d5a73d5ee5d/src/api.h
[modify] https://crrev.com/f1ac92a6f388f707b9eff32690560d5a73d5ee5d/src/builtins/builtins.cc

Labels: -Merge-approved-5.4

Sign in to add a comment