New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635753 link

Starred by 3 users
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Aug 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
nyerramilli@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD History: Old synced card left at end of list when hiding synced devices

Project Member Reported by mm00333...@techmahindra.com, Aug 9 2016 
<b>Version: <Kenneth, what is the frequency?></b>
<b>OS: <please tell me it's not XP></b>

What steps will reproduce the problem?
(1)Launch chrome -> Sign in to chrome so that history of other devices is synced 
(2)Now Go to chrome://history page ->click on "Synced Tabs"
(3) Click on 'Collapse List' option-> Now click on 'More Actions' icon and select 'Hide Menu' option 
(4)Now go to other Synced History -> Select 'Hide Menu' option   and observe 

Expected: Hide Menu should work  even on Selecting 'Collapse List' option
Actual: Instead Hide Menu is not working on Selecting 'Collapse List' option


This is Non-regression issue as this is new feature introduced from  54.0.2824.0

Comment 1 by mm00333...@techmahindra.com, Aug 9 2016

Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Below is the MANUAL CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/54.0.2823.0..54.0.2824.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/2204833003 from Manual Changelog

@tsergeant: Please feel free to re-assign if its not related to your change

Comment 2 by tsergeant@chromium.org, Aug 9 2016 

Can you please post a screenshot or a video? I am unable to reproduce.

Comment 3 by mm00333...@techmahindra.com, Aug 9 2016 

Attaching Video for reference
Untitled Screencast.webm
764 KB View Download

Comment 4 by kavvaru@chromium.org, Aug 9 2016

Labels: OS-Mac
able to reproduce the issue on Mac 10.11.6 using chrome version 54.0.2824.0

Comment 5 by mm00333...@techmahindra.com, Aug 9 2016 

Issue is also seen on Linux OS

Comment 6 by mm00333...@techmahindra.com, Aug 9 2016

Labels: OS-Linux

Comment 7 by tsergeant@chromium.org, Aug 18 2016

Labels: Proj-MaterialDesign-WebUI
Status: Started (was: Assigned)
Summary: MD History: Old synced card left at end of list when hiding synced devices (was: Non-Regression : Hide Menu is not working on Selecting 'Collapse List' option)
Thanks, able to reproduce.

We are not correctly handling the case where the list of devices shrinks
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc837d2aabc3019ccb20858e9c842270b9d68e47

commit dc837d2aabc3019ccb20858e9c842270b9d68e47
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Aug 19 06:03:11 2016

MD History: Synced Tabs fixes

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG= 635753 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2251323002
Cr-Commit-Position: refs/heads/master@{#413061}

[modify] https://crrev.com/dc837d2aabc3019ccb20858e9c842270b9d68e47/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/dc837d2aabc3019ccb20858e9c842270b9d68e47/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/dc837d2aabc3019ccb20858e9c842270b9d68e47/chrome/browser/resources/md_history/synced_device_card.html
[modify] https://crrev.com/dc837d2aabc3019ccb20858e9c842270b9d68e47/chrome/browser/resources/md_history/synced_device_card.js
[modify] https://crrev.com/dc837d2aabc3019ccb20858e9c842270b9d68e47/chrome/browser/resources/md_history/synced_device_manager.html
[modify] https://crrev.com/dc837d2aabc3019ccb20858e9c842270b9d68e47/chrome/browser/resources/md_history/synced_device_manager.js
[modify] https://crrev.com/dc837d2aabc3019ccb20858e9c842270b9d68e47/chrome/test/data/webui/md_history/history_synced_tabs_test.js

Comment 9 by tsergeant@chromium.org, Aug 19 2016

Status: Fixed (was: Started)

Comment 10 by nyerramilli@chromium.org, Aug 23 2016

Cc: nyerramilli@chromium.org
Labels: TE-Verified-M54 TE-Verified-54.0.2837.0
tested this issue on Win7, Mac OS X 10.11.6, Ubuntu 14.04 using Chrome Dev #54.0.2837.0 the fix is working as intended.

Adding TE-Verified labels.
►

Sign in to add a comment