Issue metadata
Sign in to add a comment
|
Synced Tabs: Empty space below card title for devices with no search results
Reported by
rk...@etouch.net,
Aug 9 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 54.0.2824.0 Revision facabd3224aecbcab4bea9daadad31c67488d78c-refs/heads/master@{#410520}(32/64 bit) OS: Windows(7,8,10) What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://history/syncedTabs (2) 'Sign into Chrome' with valid credentials(which have synced history) and type any keyword in search field and observe. Actual: Unnecessary space is seen below the card title. Expected: No such space should seen below the card title. This is a regression issue, broken in 'M-54', below is bisect info: Good Build: 54.0.2823.0 Bad Build: 54.0.2824.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/925fac52ddea6acceec80a70b0fae291034c05c5..bcdbb72470c705f4363a4cbe87eb8f9686b55088?pretty=fuller&n=100 Suspecting: r410304
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09e8eff19f8d9a63beff3514631f4593e0de2420 commit 09e8eff19f8d9a63beff3514631f4593e0de2420 Author: calamity <calamity@chromium.org> Date: Tue Sep 27 02:46:34 2016 [MD History] Hide empty synced device cards. This CL hides synced device cards if they have no tabs in them which can happen during search. BUG= 635749 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2360193002 Cr-Commit-Position: refs/heads/master@{#421086} [modify] https://crrev.com/09e8eff19f8d9a63beff3514631f4593e0de2420/chrome/browser/resources/md_history/lazy_load.crisper.js [modify] https://crrev.com/09e8eff19f8d9a63beff3514631f4593e0de2420/chrome/browser/resources/md_history/lazy_load.vulcanized.html [modify] https://crrev.com/09e8eff19f8d9a63beff3514631f4593e0de2420/chrome/browser/resources/md_history/synced_device_manager.html [modify] https://crrev.com/09e8eff19f8d9a63beff3514631f4593e0de2420/chrome/browser/resources/md_history/synced_device_manager.js [modify] https://crrev.com/09e8eff19f8d9a63beff3514631f4593e0de2420/chrome/test/data/webui/md_history/history_synced_tabs_test.js
,
Sep 29 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tsergeant@chromium.org
, Aug 11 2016Labels: -Pri-1 Proj-MaterialDesign-WebUI Pri-2
Owner: calamity@chromium.org
Summary: Synced Tabs: Empty space below card title for devices with no search results (was: Regression: Unnecessary space is seen below the card title in chrome://history/syncedTabs)