GN: Untangle ios and mac build configuration |
||
Issue description
//build/config/{ios,mac}/{ios,mac}_sdk.gni should only be loaded if current_os == {ios,mac} respectively. Currently //build/config/mac/mac_sdk.gni is always loaded when target_os is iOS, even if the current toolchain is the default toolchain (even though it should not be then).
This is a cleanup, not blocking M-54.
,
Apr 18 2017
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1982eef8e01ab5e8ce6aeba827faa54c8e88838a commit 1982eef8e01ab5e8ce6aeba827faa54c8e88838a Author: sdefresne <sdefresne@chromium.org> Date: Thu Apr 27 15:15:42 2017 [ios] Partially decouple iOS and macOS GN configuration. Duplicates configs defined in //build/config/mac/BUILD.gn that are shared with iOS to //build/config/ios/BUILD.gn. Remove all conditions testing "is_mac" or "is_ios" (as they are now known from the filename). Change dependencies on previously shared targets to select the correct target based on the "target_os". BUG=635745 Review-Url: https://codereview.chromium.org/2843493002 Cr-Commit-Position: refs/heads/master@{#467680} [modify] https://crrev.com/1982eef8e01ab5e8ce6aeba827faa54c8e88838a/build/config/BUILD.gn [modify] https://crrev.com/1982eef8e01ab5e8ce6aeba827faa54c8e88838a/build/config/BUILDCONFIG.gn [modify] https://crrev.com/1982eef8e01ab5e8ce6aeba827faa54c8e88838a/build/config/compiler/BUILD.gn [modify] https://crrev.com/1982eef8e01ab5e8ce6aeba827faa54c8e88838a/build/config/ios/BUILD.gn [modify] https://crrev.com/1982eef8e01ab5e8ce6aeba827faa54c8e88838a/build/config/ios/rules.gni [modify] https://crrev.com/1982eef8e01ab5e8ce6aeba827faa54c8e88838a/build/config/mac/BUILD.gn |
||
►
Sign in to add a comment |
||
Comment 1 by eugene...@chromium.org
, Apr 12 2017Components: Infra>Client>iOS