New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635743 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640844



Sign in to add a comment

Change the flag for the doc.write intervention to be a tri-state flag (default, enabled, disabled)

Project Member Reported by kenjibaheux@chromium.org, Aug 9 2016

Issue description

To allows experimentation and user control, the flag should be a tri-state (Enabled/Disabled/Default).
 
We should also make sure that we follow this best practice from now on.
Labels: Merge-Request-55
Labels: -Merge-Request-55
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a96778dfbbb5440baf247b80509a248689f26ef8

commit a96778dfbbb5440baf247b80509a248689f26ef8
Author: shivanisha <shivanisha@chromium.org>
Date: Wed Oct 19 17:18:57 2016

About flag for doc.write to be tri-state so it can be disabled.

BUG= 635743 

Review-Url: https://chromiumcodereview.appspot.com/2417313002
Cr-Commit-Position: refs/heads/master@{#426230}

[modify] https://crrev.com/a96778dfbbb5440baf247b80509a248689f26ef8/chrome/browser/about_flags.cc

Labels: Merge-Request-55

Comment 6 by dimu@chromium.org, Oct 20 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Status: Fixed (was: Available)
Merged in M55 (CL: https://chromiumcodereview.appspot.com/2438833002/)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 20 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81b7c4a2cc06a5b5a89b7c25c3216ba0c10de060

commit 81b7c4a2cc06a5b5a89b7c25c3216ba0c10de060
Author: shivanisha <shivanisha@chromium.org>
Date: Thu Oct 20 20:05:29 2016

Change about flag for doc.write to a tri-state so it can be disabled.

(cherry picked from commit 5d89eaae02f5814565f088348a6a93d48c4e9838)

BUG= 635743 
TBR=bmcquade@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://chromiumcodereview.appspot.com/2438833002
Cr-Commit-Position: refs/branch-heads/2883@{#219}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/81b7c4a2cc06a5b5a89b7c25c3216ba0c10de060/chrome/browser/about_flags.cc

Blocking: 640844
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81b7c4a2cc06a5b5a89b7c25c3216ba0c10de060

commit 81b7c4a2cc06a5b5a89b7c25c3216ba0c10de060
Author: shivanisha <shivanisha@chromium.org>
Date: Thu Oct 20 20:05:29 2016

Change about flag for doc.write to a tri-state so it can be disabled.

(cherry picked from commit 5d89eaae02f5814565f088348a6a93d48c4e9838)

BUG= 635743 
TBR=bmcquade@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://chromiumcodereview.appspot.com/2438833002
Cr-Commit-Position: refs/branch-heads/2883@{#219}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/81b7c4a2cc06a5b5a89b7c25c3216ba0c10de060/chrome/browser/about_flags.cc

Comment 11 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment