New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635741 link

Starred by 2 users
Status: Fixed
Owner:
sa...@chromium.org
Closed: Nov 2016
Cc:
█ mgiuca@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

navigator.share should be undefined on platforms other than Android

Project Member Reported by mgiuca@chromium.org, Aug 9 2016 
Version: 54
OS: Everything but Android

What steps will reproduce the problem?
(1) Run with --enable-experimental-web-platform-features.
(2) Open console.
(3) navigator.share

What is the expected output?
undefined

What do you see instead?
It's there. If you call it, it returns a promise that never resolves.

It should be undefined if there is no support on the given platform.

Sam can you look into this?

Comment 1 by mgiuca@chromium.org, Sep 8 2016 

There's a question being discussed here:
https://github.com/WICG/web-share/pull/8
as to whether we should do this, or just have it present everywhere but implement canShare.

We should probably do one or the other.

Outstanding CL: https://codereview.chromium.org/2249043002
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d59fb592c7df5a06274bbffbe5a565f01307c11

commit 4d59fb592c7df5a06274bbffbe5a565f01307c11
Author: sammc <sammc@chromium.org>
Date: Tue Oct 04 22:59:41 2016

Disable WebShare on platforms other than android.

This adds origin_trial_os_whitelist to RuntimeEnabledFeatures. If set,
an origin trial will only be available on the whitelisted OSes.

BUG= 635741 

Review-Url: https://codereview.chromium.org/2249043002
Cr-Commit-Position: refs/heads/master@{#422981}

[modify] https://crrev.com/4d59fb592c7df5a06274bbffbe5a565f01307c11/third_party/WebKit/Source/build/scripts/make_runtime_features.py
[modify] https://crrev.com/4d59fb592c7df5a06274bbffbe5a565f01307c11/third_party/WebKit/Source/build/scripts/templates/OriginTrials.cpp.tmpl
[modify] https://crrev.com/4d59fb592c7df5a06274bbffbe5a565f01307c11/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 3 by mgiuca@chromium.org, Oct 4 2016

Status: Fixed (was: Assigned)

Comment 4 by mgiuca@chromium.org, Oct 25 2016

Status: Started (was: Fixed)
I am still seeing navigator.share on a trial-enabled page on 55.0.2883.17 on Chrome OS. Will follow up later today.

Comment 5 by sa...@chromium.org, Oct 26 2016 

It turns out that generated code isn't actually used. https://codereview.chromium.org/2454513002

Comment 6 by mgiuca@chromium.org, Oct 26 2016 

Did this regress? I thought we manually tested this.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a5a4c96d03ff39adaed79d3fa0af80587e091c1

commit 3a5a4c96d03ff39adaed79d3fa0af80587e091c1
Author: sammc <sammc@chromium.org>
Date: Wed Oct 26 05:51:45 2016

Use the generated checks for whether origin trials are enabled.

BUG= 635741 

Review-Url: https://codereview.chromium.org/2454513002
Cr-Commit-Position: refs/heads/master@{#427602}

[modify] https://crrev.com/3a5a4c96d03ff39adaed79d3fa0af80587e091c1/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp

Comment 8 by mgiuca@chromium.org, Oct 27 2016

Labels: Merge-Request-55
Requesting merge to M55. Rationale: Introduced new functionality (navigator.share) which is broken.

Comment 9 by dimu@chromium.org, Oct 27 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/630e3f5d29661c40c28db20be8e668484561dd39

commit 630e3f5d29661c40c28db20be8e668484561dd39
Author: Sam McNally <sammc@chromium.org>
Date: Thu Oct 27 23:45:24 2016

Use the generated checks for whether origin trials are enabled.

BUG= 635741 

Review-Url: https://codereview.chromium.org/2454513002
Cr-Commit-Position: refs/heads/master@{#427602}
(cherry picked from commit 3a5a4c96d03ff39adaed79d3fa0af80587e091c1)

Review URL: https://codereview.chromium.org/2454253003 .

Cr-Commit-Position: refs/branch-heads/2883@{#351}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/630e3f5d29661c40c28db20be8e668484561dd39/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp

Comment 11 by sa...@chromium.org, Nov 1 2016

Status: Fixed (was: Started)
►

Sign in to add a comment